fix(toolkit-lib): join dynamic values with spaces instead of commas#1219
Open
fix(toolkit-lib): join dynamic values with spaces instead of commas#1219
Conversation
The `addDynamicValues` method joined multiple dynamic values with commas, producing invalid `cdk bootstrap` commands like: cdk bootstrap aws://acct/us-east-1,aws://acct/us-west-2 Changed to space separator so the command is valid: cdk bootstrap aws://acct/us-east-1 aws://acct/us-west-2 Also updated JSDoc comments to reflect the new separator. Closes aws/aws-cdk#31963
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 87.87% 87.79% -0.08%
==========================================
Files 73 73
Lines 10168 10168
Branches 1348 1343 -5
==========================================
- Hits 8935 8927 -8
- Misses 1209 1217 +8
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes aws/aws-cdk#31963
Reason for this change
The
addDynamicValuesmethod inNoticesFilterjoins multiple dynamic values with commas, producing invalidcdk bootstrapcommands like:Running this command fails with:
Description of changes
Changed the join separator from
,to(space) inaddDynamicValues()so the suggested command is valid:Also updated two JSDoc comments that referenced the old comma separator.
Description of how you validated changes
notices.test.tspassChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license