Skip to content

fix(toolkit-lib): join dynamic values with spaces instead of commas #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snese wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(toolkit-lib): join dynamic values with spaces instead of commas #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@aws-cdk/toolkit-lib/lib/api/notices/filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ interface ActualComponent {
* placeholders look like `{resolve:XYZ}`.
*
* If there is more than one component with the same dynamic name, they are
* joined by ','.
* joined by ' '.
*
* @default - Don't add to the set of dynamic values
*/
Expand Down Expand Up @@ -188,7 +188,7 @@ export class NoticesFilter {
* Adds dynamic values from the given ActualComponents
*
* If there are multiple components with the same dynamic name, they are joined
* by a comma.
* by a space.
*/
private addDynamicValues(comps: ActualComponent[], notice: FilteredNotice) {
const dynamicValues: Record<string, string[]> = {};
Expand All @@ -199,7 +199,7 @@ export class NoticesFilter {
}
}
for (const [key, values] of Object.entries(dynamicValues)) {
notice.addDynamicValue(key, values.join(','));
notice.addDynamicValue(key, values.join(' '));
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/toolkit-lib/test/api/notices.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ describe(NoticesFilter, () => {
bootstrappedEnvironments: bootstrappedEnvironments,
});
expect((await filtered).map((f) => f.notice)).toEqual([BASIC_BOOTSTRAP_NOTICE]);
expect((await filtered).map((f) => f.format()).join('\n')).toContain('env1,env2');
expect((await filtered).map((f) => f.format()).join('\n')).toContain('env1 env2');
});

test('ignores invalid bootstrap versions', async () => {
Expand Down
Loading