Skip to content

Adding Notification for Capacity Shutdown for 1.1#158

Merged
aakashmandavilli96 merged 2 commits intoaws:1.1from
jatinkulkarni:1.1
Feb 26, 2026
Merged

Adding Notification for Capacity Shutdown for 1.1#158
aakashmandavilli96 merged 2 commits intoaws:1.1from
jatinkulkarni:1.1

Conversation

@jatinkulkarni
Copy link

Issue

Description of Changes

Implements FTP Capacity Block Expiration Notification feature for SageMaker extension. Adds three-tier notification system (30min, 10min, 2min warnings) to alert users before capacity block expiration, preventing unexpected data loss.

Key additions:

  • capacityBlockWarning.ts - notification display logic
  • constant.ts - CB notification constants and metadata interfaces
  • extension.ts - monitoring initialization, scheduling, cleanup
  • sagemaker.series - patch file registration

Technical highlights:

  • Handles setTimeout limits for long-duration blocks (>24 days) via 7-day periodic rechecks
  • Auto-reschedules if capacity block extended (1min tolerance)
  • Accounts for EC2's 30min shutdown window
  • Toast notifications at 30/10min, modal at 2min with "Save All" option

Testing

Tested via GitHub Actions workflow on feature branch with DISABLE_MANGLE=true. Build artifacts generated successfully. Verified notification scheduling logic and timeout handling.

Screenshots/Videos

Image (3) Image (4) Image (5)

Additional Notes

Changes limited to SageMaker-specific directories (patches/sagemaker/), enabling SageMaker team self-approval per CODEOWNERS. Feature enhances UX by preventing data loss during capacity block expiration with defensive error handling and graceful degradation.

Backporting


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

skazantsev
skazantsev previously approved these changes Feb 24, 2026
@aws-ajangg
Copy link

Otherwise, LGTM

@jatinkulkarni
Copy link
Author

Otherwise, LGTM

Removed those commented out notification messages

Copy link

@aakashmandavilli96 aakashmandavilli96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aakashmandavilli96 aakashmandavilli96 merged commit c879fe7 into aws:1.1 Feb 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants