Fix issue overflow when reading data

[urbytes21]

No description provided.

[urbytes21]

Hi @bertmelis ,
size is the target read size, retVal is the bytes already read,
So I think we should change the loop condition to while (size > retVal) instead of checking pxItemSize.

Please help me review this PR.
Many thanks.

[bertmelis]

Thanks!

I'm a bit struggling with an off-by-1 buffer usage because a check for buffer size greater than retval instead of greater or equal. When eventually size - retVal reaches 0, the function returns NULL and we exit the loop.

[urbytes21]

Hi @bertmelis ,
Thanks for pointing this out. The logic itself is correct, and there’s no off-by-one issue, but I agree it’s a bit unclear to rely on a zero-length receive returning NULL to exit the loop.

I've updated to make it clearer. Please help me review.
Thank you.