Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ clap_mangen = { version = "0.2.20" }
# composefs-boot = { path = "/home/user/src/composefs-rs/crates/composefs-boot" }
# composefs-oci = { path = "/home/user/src/composefs-rs/crates/composefs-oci" }
# The Justfile will auto-detect these and bind-mount them into container builds.
composefs = { git = "https://github.com/containers/composefs-rs", rev = "ce3cd9bf7aa0ad2ee8d3814101aa9cd50fd3598d", package = "composefs", features = ["rhel9"] }
composefs-boot = { git = "https://github.com/containers/composefs-rs", rev = "ce3cd9bf7aa0ad2ee8d3814101aa9cd50fd3598d", package = "composefs-boot" }
composefs-oci = { git = "https://github.com/containers/composefs-rs", rev = "ce3cd9bf7aa0ad2ee8d3814101aa9cd50fd3598d", package = "composefs-oci" }
composefs = { git = "https://github.com/containers/composefs-rs", rev = "0c6134653d66ac42c43bac4e1298bfb626aeba87", package = "composefs", features = ["rhel9"] }
composefs-boot = { git = "https://github.com/containers/composefs-rs", rev = "0c6134653d66ac42c43bac4e1298bfb626aeba87", package = "composefs-boot" }
composefs-oci = { git = "https://github.com/containers/composefs-rs", rev = "0c6134653d66ac42c43bac4e1298bfb626aeba87", package = "composefs-oci" }
fn-error-context = "0.2.1"
hex = "0.4.3"
indicatif = "0.18.0"
Expand Down
2 changes: 1 addition & 1 deletion crates/ostree-ext/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ xshell = { workspace = true, optional = true }

# Crate-specific dependencies
comfy-table = "7.1.1"
containers-image-proxy = "0.9.1"
containers-image-proxy = "0.9.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to ensure version consistency across the workspace, it's a good practice to manage shared dependencies in the root Cargo.toml. Since containers-image-proxy is also a dependency of another crate in your dependency tree (composefs-oci), consider moving its definition to the [workspace.dependencies] table and inheriting it here.

This would involve adding the following to the [workspace.dependencies] section of the root Cargo.toml:

containers-image-proxy = "0.9.2"

And then changing this line to use the workspace definition.

Suggested change
containers-image-proxy = "0.9.2"
containers-image-proxy = { workspace = true }

flate2 = { features = ["zlib"], default-features = false, version = "1.0.20" }
futures-util = "0.3.13"
gvariant = "0.5.0"
Expand Down
Loading