fix: handle GitHub API rate limits in install scripts#350
Open
brycelelbach wants to merge 1 commit intobrevdev:mainfrom
Open
fix: handle GitHub API rate limits in install scripts#350brycelelbach wants to merge 1 commit intobrevdev:mainfrom
brycelelbach wants to merge 1 commit intobrevdev:mainfrom
Conversation
The install scripts used `curl -s` which silently swallows HTTP errors. When the GitHub API returns a 403 (rate limit) or other failure, the scripts would either print a misleading "Could not find release" error or, in the case of install-latest-linux.sh, proceed with an empty URL. Switch to `curl -sf` so HTTP errors produce a non-zero exit code, and add explicit error handling with a clear message about rate limiting. Also add a missing empty-URL guard to install-latest-linux.sh.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Fetch release metadata from GitHub API | ||
| API_RESPONSE="$(curl -sf https://api.github.com/repos/brevdev/brev-cli/releases/latest 2>&1)" || { | ||
| echo "Error: Failed to fetch release info from GitHub API." >&2 | ||
| echo "This may be caused by rate limiting. Try again later or set a GITHUB_TOKEN." >&2 |
Contributor
There was a problem hiding this comment.
does setting a GITHUB_TOKEN work? we don't utilize it anywhere, right? Wouldn't the curl need to conditionally check for it?
Also, since the people who see this the most are likely on a VPN:
echo "Error: Failed to fetch release info from GitHub API." >&2
echo "This is often caused by rate limiting when many requests come from the same IP." >&2
echo "If you are using a VPN, try turning it off and running this script again." >&2
echo "For more details, see: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting" >&2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/install-latest.sh,bin/install-latest-linux.sh) usecurl -sto fetch release metadata from the GitHub API. The-sflag silently swallows HTTP errors, so when the API returns a 403 (rate limit) or any other failure, the scripts either print a misleading "Could not find release" error or, in the case ofinstall-latest-linux.sh, proceed with an empty download URL.curl -sfso HTTP errors produce a non-zero exit code, and add explicit error handling with a clear message about rate limiting.install-latest-linux.sh.Test plan
bin/install-latest.shnormally and verify it still installs successfully.bin/install-latest-linux.shon a Linux host and verify the same behavior.