Open
Conversation
The install scripts used `curl -s` which silently swallows HTTP errors. When the GitHub API returns a 403 (rate limit) or other failure, the scripts would either print a misleading "Could not find release" error or, in the case of install-latest-linux.sh, proceed with an empty URL. Switch to `curl -sf` so HTTP errors produce a non-zero exit code, and add explicit error handling with a clear message about rate limiting. Also add a missing empty-URL guard to install-latest-linux.sh.
drewmalin
previously approved these changes
Apr 14, 2026
|
|
||
| # Verify we found a suitable release | ||
| # Extract the download URL for this platform | ||
| DOWNLOAD_URL="$(echo "${API_RESPONSE}" | grep "browser_download_url.*${OS}.*${ARCH}" | cut -d '"' -f 4)" |
Contributor
There was a problem hiding this comment.
Bit of a corner case but since we have both -o pipefail (treat any command failure in a pipe as the cause of the pipefail) and -e (treat any command failure as a full script failure) if grep doesn't find the line it's looking for, which will prompt a 1 exit code from grep, then we will just fail rather than moving on to the below if-statement.
Contributor
Author
There was a problem hiding this comment.
Used Claude to add a || true which should just swallow the exit code and rely on whatever DOWNLOAD_URL is to decide what to do.
| @@ -1,8 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
Does anything use this file anymore?
Contributor
Author
There was a problem hiding this comment.
doesn't look like it. I'll remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iteration of #350