chore: baseline styling screenshots (pre-fix) by paddymul · Pull Request #607 · buckaroo-data/buckaroo

paddymul · 2026-02-27T18:53:05Z

Captures baseline styling screenshots from commit e392c78 (before #587, #599, #597 fixes). Do not merge.

Stories, Playwright spec, CI job, and compare tools — applied to pre-fix commit e392c78 (before #587, #599, #597). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-27T18:55:11Z

📦 TestPyPI package published

pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.12.dev22506565423

or with uv:

uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.12.dev22506565423

MCP server for Claude Code

claude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.12.12.dev22506565423" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4f892ddfa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T19:10:31Z

.github/workflows/checks.yml

+          name: styling-screenshots
+          path: packages/buckaroo-js-core/screenshots/styling/


Align artifact name with styling screenshot downloader

The new workflow uploads a single artifact named styling-screenshots, but scripts/download_styling_screenshots.sh tries to download styling-screenshots-before and styling-screenshots-after from the same run. In this configuration, the helper script cannot fetch screenshots produced by this job, so the before/after comparison flow is broken for every run of this workflow.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…croll Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…erflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fitCellContents never crushes columns, so use ag_grid_specs maxWidth to cap columns at 50px. 7-digit data should show "..." truncation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Same story definition as the fix branch, but baseline has no defaultColDef.minWidth so columns stay at 40px → data shows "..." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Same story as the fix branch but without defaultColDef.minWidth, so fitGridWidth crushes 15 columns into ~53px each → data shows "..." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

add screenshot apparatus for baseline styling comparison

d4f892d

Stories, Playwright spec, CI job, and compare tools — applied to pre-fix commit e392c78 (before #587, #599, #597). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 18:54 — with GitHub Actions Inactive

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

fix: checkout PR head SHA for screenshots, not merge ref

135bc52

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 19:45 — with GitHub Actions Inactive

fix: scroll grid body in pinned-index screenshots to expose #587

137f480

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 19:55 — with GitHub Actions Inactive

fix: pierce shadow DOM for pinned-index scroll in screenshots

bed58fa

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 20:09 — with GitHub Actions Inactive

fix: walk all shadow roots to find ag-body-viewport for scroll

594dc74

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 20:18 — with GitHub Actions Inactive

fix: use long headers in pinned stories so grid requires horizontal s…

87a3d5b

…croll Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 20:26 — with GitHub Actions Inactive

fix: use 400px container for pinned stories to force horizontal scroll

9a5a30f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 20:57 — with GitHub Actions Inactive

fix: add minWidth:120 via ag_grid_specs on pinned stories to force ov…

5dae69f

…erflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 21:07 — with GitHub Actions Inactive

fix: use keyboard End key to scroll pinned stories to rightmost column

b4c214d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 21:14 — with GitHub Actions Inactive

feat: add A9 story for #595 — many cols, long headers, year-like data

f123635

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 21:31 — with GitHub Actions Inactive

paddymul and others added 2 commits February 27, 2026 17:00

fix: A9 story — 25 long cols in 400px to force data truncation (#595)

2b4c1e7

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: A9 — force maxWidth:50 on columns to reproduce #595 truncation

72abf2f

fitCellContents never crushes columns, so use ag_grid_specs maxWidth to cap columns at 50px. 7-digit data should show "..." truncation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 22:01 — with GitHub Actions Inactive

fix: update A9 story to use width:40 + suppressAutoSize for #595 repro

b74e0ed

Same story definition as the fix branch, but baseline has no defaultColDef.minWidth so columns stay at 40px → data shows "..." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 22:27 — with GitHub Actions Inactive

fix: update A9 story to use fitGridWidth + autoSizeStrategy override

dca9ada

Same story as the fix branch but without defaultColDef.minWidth, so fitGridWidth crushes 15 columns into ~53px each → data shows "..." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 22:34 — with GitHub Actions Inactive

fix: update A9 story to 25 cols for visible truncation repro

37ce057

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

paddymul temporarily deployed to testpypi February 27, 2026 22:39 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: baseline styling screenshots (pre-fix)#607

chore: baseline styling screenshots (pre-fix)#607
paddymul wants to merge 15 commits intomainfrom
screenshots/baseline

paddymul commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		name: styling-screenshots
		path: packages/buckaroo-js-core/screenshots/styling/

Conversation

paddymul commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 TestPyPI package published

MCP server for Claude Code

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Feb 27, 2026 •

edited

Loading