chore: baseline styling screenshots (pre-fix)

.github/workflows/checks.yml

@@ -407,6 +407,47 @@ jobs:
           path: packages/buckaroo-js-core/screenshots/
           if-no-files-found: ignore
 
+  StylingScreenshots:
+    name: Styling Screenshots
+    runs-on: depot-ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          ref: ${{ github.event.pull_request.head.sha || github.sha }}
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 9.10.0
+      - name: Setup Node.js with pnpm cache
+        uses: actions/setup-node@v6
+        with:
+          cache: 'pnpm'
+          cache-dependency-path: 'packages/pnpm-lock.yaml'
+      - name: Install pnpm dependencies
+        working-directory: packages
+        run: pnpm install --no-frozen-lockfile
+      - name: Cache Playwright browsers
+        uses: actions/cache@v5
+        with:
+          path: ~/.cache/ms-playwright
+          key: playwright-${{ hashFiles('packages/buckaroo-js-core/package.json') }}
+      - name: Install Playwright browsers
+        working-directory: packages/buckaroo-js-core
+        run: pnpm exec playwright install chromium
+      - name: Capture screenshots
+        working-directory: packages/buckaroo-js-core
+        env:
+          SCREENSHOT_DIR: screenshots/styling
+        run: pnpm exec playwright test pw-tests/styling-issues-screenshots.spec.ts --reporter=line
+      - name: Upload screenshots
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: styling-screenshots
+          path: packages/buckaroo-js-core/screenshots/styling/
+          if-no-files-found: ignore
+
   TestServer:
     name: Server Playwright Tests
     needs: [BuildWheel]

packages/buckaroo-js-core/pw-tests/styling-issues-screenshots.spec.ts

@@ -0,0 +1,107 @@
+/**
+ * Playwright screenshot capture for styling-issue stories.
+ * Follows the theme-screenshots.spec.ts pattern (light-only).
+ *
+ * SCREENSHOT_DIR env var controls output directory (default: screenshots/after).
+ * Run once on each commit to produce "before" and "after" sets:
+ *
+ *   SCREENSHOT_DIR=screenshots/before npx playwright test pw-tests/styling-issues-screenshots.spec.ts
+ *   SCREENSHOT_DIR=screenshots/after  npx playwright test pw-tests/styling-issues-screenshots.spec.ts
+ */
+import { test } from '@playwright/test';
+import path from 'path';
+import fs from 'fs';
+import { fileURLToPath } from 'url';
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+
+const STORYBOOK_BASE = 'http://localhost:6006/iframe.html?viewMode=story&id=';
+
+// Output directory — overridable via env var
+const screenshotsDir = path.resolve(
+  __dirname,
+  '..',
+  process.env.SCREENSHOT_DIR ?? 'screenshots/after',
+);
+
+/**
+ * All 16 styling-issue stories.
+ * Story IDs follow Storybook's slug rules:
+ *   title "Buckaroo/DFViewer/StylingIssues" → "buckaroo-dfviewer-stylingissues"
+ *   export name e.g. FewCols_ShortHdr_ShortData → "few-cols-short-hdr-short-data"
+ *   (Storybook runs startCase() on the export name before slugifying)
+ */
+const STORIES = [
+  // Section A – width/contention (#595, #596, #599, #600)
+  { id: 'buckaroo-dfviewer-stylingissues--few-cols-short-hdr-short-data',  name: 'A1_FewCols_ShortHdr_ShortData',  issues: '#599' },
+  { id: 'buckaroo-dfviewer-stylingissues--few-cols-short-hdr-long-data',   name: 'A2_FewCols_ShortHdr_LongData',   issues: '' },
+  { id: 'buckaroo-dfviewer-stylingissues--few-cols-long-hdr-short-data',   name: 'A3_FewCols_LongHdr_ShortData',   issues: '' },
+  { id: 'buckaroo-dfviewer-stylingissues--few-cols-long-hdr-long-data',    name: 'A4_FewCols_LongHdr_LongData',    issues: '' },
+  { id: 'buckaroo-dfviewer-stylingissues--many-cols-short-hdr-short-data', name: 'A5_ManyCols_ShortHdr_ShortData', issues: '#595 #599' },
+  { id: 'buckaroo-dfviewer-stylingissues--many-cols-short-hdr-long-data',  name: 'A6_ManyCols_ShortHdr_LongData',  issues: '#596' },
+  { id: 'buckaroo-dfviewer-stylingissues--many-cols-long-hdr-short-data',  name: 'A7_ManyCols_LongHdr_ShortData',  issues: '#596' },
+  { id: 'buckaroo-dfviewer-stylingissues--many-cols-long-hdr-long-data',   name: 'A8_ManyCols_LongHdr_LongData',   issues: '#596 worst-case' },
+  { id: 'buckaroo-dfviewer-stylingissues--many-cols-long-hdr-year-data',  name: 'A9_ManyCols_LongHdr_YearData',   issues: '#595 primary' },
+
+  // Section B – large numbers / compact_number (#597, #602)
+  // Note: compact_number stories may render raw values on pre-#597 commits.
+  { id: 'buckaroo-dfviewer-stylingissues--large-numbers-float',            name: 'B9_LargeNumbers_Float',          issues: '#597 before' },
+  { id: 'buckaroo-dfviewer-stylingissues--large-numbers-compact',          name: 'B10_LargeNumbers_Compact',        issues: '#597 after' },
+  { id: 'buckaroo-dfviewer-stylingissues--clustered-billions-float',       name: 'B11_ClusteredBillions_Float',     issues: '#602 baseline' },
+  { id: 'buckaroo-dfviewer-stylingissues--clustered-billions-compact',     name: 'B12_ClusteredBillions_Compact',   issues: '#602 precision' },
+
+  // Section C – pinned row / index alignment (#587)
+  { id: 'buckaroo-dfviewer-stylingissues--pinned-index-few-cols',          name: 'C13_PinnedIndex_FewCols',         issues: '#587' },
+  { id: 'buckaroo-dfviewer-stylingissues--pinned-index-many-cols',         name: 'C14_PinnedIndex_ManyCols',        issues: '#587' },
+
+  // Section D – mixed cross-issue scenarios
+  { id: 'buckaroo-dfviewer-stylingissues--mixed-many-narrow-with-pinned',  name: 'D15_Mixed_ManyNarrow_WithPinned', issues: '#595 #587 #599' },
+  { id: 'buckaroo-dfviewer-stylingissues--mixed-few-wide-with-pinned',     name: 'D16_Mixed_FewWide_WithPinned',    issues: '#587 baseline' },
+];
+
+test.beforeAll(() => {
+  fs.mkdirSync(screenshotsDir, { recursive: true });
+});
+
+for (const story of STORIES) {
+  test(`screenshot ${story.name}`, async ({ page }) => {
+    await page.emulateMedia({ colorScheme: 'light' });
+    await page.goto(`${STORYBOOK_BASE}${story.id}`);
+
+    // Wait for AG-Grid cells or any visible content
+    const cell        = page.locator('.ag-cell');
+    const cellWrapper = page.locator('.ag-cell-wrapper');
+    const noRows      = page.locator('.ag-overlay-no-rows-center');
+    const fullWidth   = page.locator('.ag-full-width-row');
+    const sbContent   = page.locator('#storybook-root');
+
+    await cell
+      .or(cellWrapper)
+      .or(noRows)
+      .or(fullWidth)
+      .or(sbContent)
+      .first()
+      .waitFor({ state: 'visible', timeout: 15000 });
+
+    // Settle time for animations / lazy column-width calculation
+    await page.waitForTimeout(800);
+
+    // For pinned-index stories, scroll the grid body right so the
+    // index column is out of view — exposes #587 alignment bug.
+    // Use keyboard End key to scroll to the rightmost column.
+    if (story.name.includes('Pinned')) {
+      // Click a cell first to give the grid focus
+      const firstCell = page.locator('.ag-cell').first();
+      await firstCell.click();
+      await page.waitForTimeout(200);
+      // Press End to scroll to the last column
+      await page.keyboard.press('End');
+      await page.waitForTimeout(400);
+    }
+
+    await page.screenshot({
+      path: path.join(screenshotsDir, `${story.name}.png`),
+      fullPage: true,
+    });
+  });
+}

packages/buckaroo-js-core/src/components/DFViewerParts/DFViewerInfinite.tsx

@@ -303,7 +303,7 @@ export function DFViewerInfiniteInner({
         return {
         ...outerGridOptions(setActiveCol, df_viewer_config.extra_grid_config),
         domLayout:  hs.domLayout,
-        autoSizeStrategy: getAutoSize(styledColumns.length),
+        autoSizeStrategy: df_viewer_config.extra_grid_config?.autoSizeStrategy || getAutoSize(styledColumns.length),
         onFirstDataRendered: (_params) => {
             // Grid finished rendering
         },