Require confirmation for spacetime delete#4770
Open
clockwork-labs-bot wants to merge 1 commit intomasterfrom
Open
Require confirmation for spacetime delete#4770clockwork-labs-bot wants to merge 1 commit intomasterfrom
spacetime delete#4770clockwork-labs-bot wants to merge 1 commit intomasterfrom
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spacetime deletesends an irreversible delete request--yesas the non-interactive overriden, deleting ony, and skipping the prompt with--yesCloses #4679.
History note
spacetime deletehas never required confirmation for ordinary deletes. The command was added in commit44df6c6e7(Initial commit, 2023-08-01) without a prompt. Later, commita36f7091d([teams 3/5] API authorization, CLI, smoketests, 2025-11-11) added a confirmation flow only for the special case where deleting a database would also delete its children, but plain deletes still executed immediately until this change.Testing
cargo check -p spacetimedb-clicargo build --release -p spacetimedb-cli -p spacetimedb-standalone --features spacetimedb-standalone/allow_loopback_http_for_testscd crates/smoketests/modules && cargo build --release --target wasm32-unknown-unknown -p smoketest-module-delete-databasecargo test -p spacetimedb-smoketests --test integration delete_database -- --nocapture