Fix: accessible title in cloud snippet search results#343
Merged
Fix: accessible title in cloud snippet search results#343
Conversation
louiswol94
approved these changes
Apr 10, 2026
imantsk
reviewed
Apr 14, 2026
| color: #2271b1; | ||
| cursor: pointer; | ||
| text-align: start; | ||
| text-decoration: underline; |
Member
There was a problem hiding this comment.
what do you say about, no underline by default, but only when hover or focus?
Contributor
Author
There was a problem hiding this comment.
Underlining links is a primary accessibility best practice because it ensures that color is not the only way to identify interactive text.
While the Web Content Accessibility Guidelines (WCAG) do not strictly mandate underlines, they do require that links be visually distinguishable from surrounding text.
I prefer to keep the underline on the link.
sheabunge
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
<a href="#">with<button>to improve semantics. Links are used only for linking to other pages. In this case, clicking the title open a modal. So, it's not a link.The change also makes keyboard navigation more intuitive. Before you could open only with ENTER, after the change you can use either ENTER or SPACE.
Before:
After: