Skip to content

Fix: accessible title in cloud snippet search results #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheabunge merged 2 commits into from
Apr 15, 2026
+24 −5
Merged

Fix: accessible title in cloud snippet search results #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f97c7
Fix: accessible title in cloud snippet search results
rami-elementor Apr 10, 2026
05099e5
Update
rami-elementor Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/css/manage/_cloud-community.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,25 @@

.cloud-snippet {
padding: 24px;

.cloud-snippet-title-button {
display: inline;
margin: 0;
padding: 0;
border: none;
background: none;
font: inherit;
color: #2271b1;
cursor: pointer;
text-align: start;
text-decoration: underline;
Copy link
Copy Markdown
Member

@imantsk imantsk Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you say about, no underline by default, but only when hover or focus?

Copy link
Copy Markdown
Contributor Author

@rami-elementor rami-elementor Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underlining links is a primary accessibility best practice because it ensures that color is not the only way to identify interactive text.

While the Web Content Accessibility Guidelines (WCAG) do not strictly mandate underlines, they do require that links be visually distinguishable from surrounding text.

I prefer to keep the underline on the link.


&:focus-visible {
outline: 2px solid #2271b1;
outline-offset: 2px;
border-radius: 2px;
}
}
}

.cloud-snippet-meta {
Expand Down
10 changes: 5 additions & 5 deletions src/js/components/ManageMenu/CommunityCloud/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ interface CloudSnippetDetailsProps {
const CloudSnippetDetails: React.FC<CloudSnippetDetailsProps> = ({ snippet, setIsPreviewOpen }) =>
<div className="cloud-snippet">
<h3>
<a
href="#"
<button
type="button"
className="cloud-snippet-title-button"
title={__('Preview this snippet', 'code-snippets')}
onClick={event => {
event.preventDefault()
onClick={() => {
setIsPreviewOpen(true)
}}
>
{snippet.name}
</a>
</button>
</h3>

<div className="cloud-snippet-meta">
Expand Down
Loading