Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a “Remove member” action to the Note Settings team list, wiring UI → application/domain → repository API to remove a collaborator (with confirmation) and refresh the displayed settings.
Changes:
- Add a per-member “More actions” context menu with a “Remove” option and confirmation flow.
- Bubble a “team member removed” event up to NoteSettings to reload note settings/team.
- Add
removeMemberByUserIdthrough repository/service/composable layers and introduce new i18n strings.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/presentation/pages/NoteSettings.vue | Listens for member-removed event and reloads note settings. |
| src/presentation/components/team/Team.vue | Renders new per-member actions component and re-emits removal event upward. |
| src/presentation/components/team/MoreActions.vue | New UI component showing context menu + confirmation + remove call. |
| src/infrastructure/noteSettings.repository.ts | Adds DELETE call to remove a team member by userId. |
| src/domain/noteSettings.service.ts | Exposes removeMemberByUserId in domain service. |
| src/domain/noteSettings.repository.interface.ts | Extends repository interface with removeMemberByUserId. |
| src/application/services/useNoteSettings.ts | Adds composable method for removing a team member. |
| src/application/i18n/messages/en.json | Adds menu label and confirmation copy for removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e11sy
reviewed
Feb 7, 2026
e11sy
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to remove a team member from a note.
Users with 'write' access to a note can now remove other members from its team.
In the note's settings menu, a new "Remove" option has been added to the context menu (located right after role selector). This action requires confirmation before the member is actually removed.