-
Notifications
You must be signed in to change notification settings - Fork 6
Feat: remove team member #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7ff9cb5
feat: add ability to remove team member
7eliassen a9d9d4b
chore: lint fixes
7eliassen 2057faa
chore: small fixes
7eliassen 98111c0
chore: add error handle
7eliassen 879ff7c
refactor: removeTeamMember optimization
7eliassen ccfe732
feat: display whom you want to remove
7eliassen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| <template> | ||
| <button | ||
| ref="triggerButton" | ||
| :title="t('noteSettings.team.contextMenu.title')" | ||
| class="more-actions-button" | ||
| @click="handleButtonClick" | ||
| > | ||
| <Icon | ||
| name="EtcVertical" | ||
| /> | ||
| </button> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { ref } from 'vue'; | ||
| import { Icon, ContextMenu, usePopover, useConfirm, type ContextMenuItem } from '@codexteam/ui/vue'; | ||
| import { type TeamMember } from '@/domain/entities/Team'; | ||
| import { useI18n } from 'vue-i18n'; | ||
| import { NoteId } from '@/domain/entities/Note'; | ||
| import useNoteSettings from '@/application/services/useNoteSettings'; | ||
|
|
||
| const { removeMemberByUserId } = useNoteSettings(); | ||
7eliassen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const props = defineProps<{ | ||
| /** | ||
| * Team member data | ||
| */ | ||
| teamMember: TeamMember; | ||
| /** | ||
| * Id of the current note | ||
| */ | ||
| noteId: NoteId; | ||
| }>(); | ||
|
|
||
| const { t } = useI18n(); | ||
| const { showPopover, hide } = usePopover(); | ||
| const { confirm } = useConfirm(); | ||
|
|
||
| const triggerButton = ref<HTMLButtonElement>(); | ||
|
|
||
| const menuItems: ContextMenuItem[] = [ | ||
| { | ||
| title: t('noteSettings.team.contextMenu.remove'), | ||
| onActivate: async () => { | ||
| hide(); | ||
| await handleRemove(props.teamMember); | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| const emit = defineEmits<{ | ||
| teamMemberRemoved: [userId: TeamMember['user']['id']]; | ||
| }>(); | ||
|
|
||
| const handleButtonClick = (): void => { | ||
| if (triggerButton.value) { | ||
| showPopover({ | ||
| targetEl: triggerButton.value, | ||
| with: { | ||
| component: ContextMenu, | ||
| props: { | ||
| items: menuItems, | ||
| }, | ||
| }, | ||
| align: { | ||
| vertically: 'below', | ||
| horizontally: 'right', | ||
| }, | ||
| width: 'auto', | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Remove team member by user id | ||
| * | ||
| * @param member - team member to remove | ||
| */ | ||
| const handleRemove = async (member: TeamMember): Promise<void> => { | ||
| const shouldRemove = await confirm( | ||
| t('noteSettings.team.removeMemberConfirmationTitle'), | ||
| t('noteSettings.team.removeMemberConfirmationBody', { username: member.user.name }) | ||
| ); | ||
|
|
||
| if (shouldRemove) { | ||
| const isDeleted = await removeMemberByUserId(props.noteId, member.user.id); | ||
|
|
||
| if (isDeleted) { | ||
| emit('teamMemberRemoved', member.user.id); | ||
| } | ||
| } | ||
| }; | ||
| </script> | ||
|
|
||
| <style scoped> | ||
| .more-actions-button { | ||
| color: var(--ct-text-color-primary); | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| border: none; | ||
| cursor: pointer; | ||
| } | ||
| </style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.