-
Notifications
You must be signed in to change notification settings - Fork 39
Fix compatibility with roslibpy 2.0.0 and improve CI build system #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
63ff3b6
Initial plan
Copilot 27158d3
Fix roslibpy 2.0.0 compatibility by adding upper bound constraint
Copilot 000629d
Remove pybullet from dev requirements to fix CI build
Copilot 2b65525
Re-add pybullet with platform marker to skip macOS Python 3.9
Copilot 190d1e4
Switch to conda for pybullet installation
Copilot 5bebc93
Restructure environment.yml per review feedback
Copilot 6a9521a
Update ironpython workflow from main branch
Copilot 1c0f0ee
Pin roslibpy to version 1.8.1 in ironpython workflow
Copilot f3db57a
List dev dependencies explicitly in environment.yml
Copilot 3214051
Update COMPAS version to 2.14.1 in ironpython workflow
Copilot a6c4bfe
oh lord, save me from this nightmare
gonzalocasas 0826764
use cmd shell
gonzalocasas 41f8f7e
Add LTS-main-1.x branch to workflows
gonzalocasas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: compas_fab | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python>=3.9 | ||
| - pip | ||
| - compas >= 2.0.4, < 3 | ||
| - compas_robots >= 0.3, < 1 | ||
| - roslibpy >= 1.1, < 2 | ||
| - pyserial | ||
| - pybullet | ||
| - pip: | ||
| - attrs >=19.3.0 | ||
| - black | ||
| - bump2version >=1.0.1 | ||
| - check-manifest >=0.36 | ||
| - compas-invocations2 | ||
| - ruff | ||
| - importlib_metadata <5.0 | ||
| - invoke>=0.14 | ||
| - pytest | ||
| - pytest_mock | ||
| - pytest-cov | ||
| - sphinx_compas2_theme | ||
| - sybil~=8.0.1 | ||
| - twine | ||
| - tomlkit | ||
| - -e . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| compas >= 2.0.4, < 3 | ||
| compas_robots >= 0.3, < 1 | ||
| roslibpy >= 1.1.0 | ||
| roslibpy >= 1.1, < 2 | ||
| pyserial |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot fix this to download specifically 1.8.1:
https://pypi.debian.net/roslibpy/roslibpy-1.8.1.tar.gzThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1c0f0ee. Changed roslibpy download URL to specifically version 1.8.1.