fix: prevent path traversal in exportEnvironmentFile#339
Open
zerone0x wants to merge 1 commit intodagger:mainfrom
Open
fix: prevent path traversal in exportEnvironmentFile#339zerone0x wants to merge 1 commit intodagger:mainfrom
zerone0x wants to merge 1 commit intodagger:mainfrom
Conversation
Add boundary check after filepath.Join to ensure the resolved file path stays within the worktree directory. Without this validation, a malicious target_file like "../../.bashrc" could write files outside the worktree on the host filesystem via the environment_file_write MCP tool. Fixes dagger#337 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportEnvironmentFilewhere user-controlledtarget_filepaths containing..sequences could write files outside the worktree directory on the host filesystemfilepath.Relafterfilepath.Jointo ensure the resolved path stays within the worktreeFixes #337
Test plan
go build ./...compiles successfullygo test -short ./...passes (2 pre-existing failures inTestSelectiveFileStagingunrelated to this change)../../.bashrcare rejected with "path traversal detected" errorsrc/main.gocontinue to work as expected