Skip to content

fix: prevent path traversal in exportEnvironmentFile #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerone0x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent path traversal in exportEnvironmentFile #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions repository/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,12 @@ func (r *Repository) exportEnvironmentFile(ctx context.Context, env *environment
// Get the absolute path for the file in the worktree
absoluteFilePath := filepath.Join(worktreePath, filePath)

// Validate the resolved path stays within the worktree to prevent path traversal
rel, err := filepath.Rel(worktreePath, absoluteFilePath)
if err != nil || strings.HasPrefix(rel, "..") {
return fmt.Errorf("path traversal detected: %s resolves outside worktree", filePath)
}

// Ensure the directory exists
if err := os.MkdirAll(filepath.Dir(absoluteFilePath), 0755); err != nil {
return fmt.Errorf("failed to create directory for file %s: %w", filePath, err)
Expand Down