feat: data output period types (DHIS2-21001)#3458
Open
janhenrikoverland wants to merge 11 commits intomasterfrom
Open
feat: data output period types (DHIS2-21001)#3458janhenrikoverland wants to merge 11 commits intomasterfrom
janhenrikoverland wants to merge 11 commits intomasterfrom
Conversation
Contributor
|
🚀 Deployed on https://pr-3458.data-visualizer.netlify.dhis2.org |
edoardo
previously approved these changes
Mar 6, 2026
janhenrikoverland
added
the
e2e record
|
data-visualizer-app
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
data-visualizer-app
|
| Branch Review |
feat/data-output-period-types
|
| Run status |
|
| Run duration | 10m 56s |
| Commit |
|
| Committer | Jan Henrik Øverland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
4
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
740
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/dimensions/period.cy.js • 1 failed test • e2e-chrome-parallel-41-2
| Test | Artifacts | |
|---|---|---|
| Period dimension > using period settings > works correctly when "weekly" is hidden |
Test Replay
Screenshots
Video
|
|
cypress/integration/dimensions/period.cy.js • 1 failed test • e2e-chrome-parallel-42-2
| Test | Artifacts | |
|---|---|---|
| Period dimension > using period settings > works correctly when "weekly" is hidden |
Test Replay
Screenshots
Video
|
|
cypress/integration/dimensions/period.cy.js • 1 failed test • e2e-chrome-parallel-40-2
| Test | Artifacts | |
|---|---|---|
| Period dimension > using period settings > works correctly when "weekly" is hidden |
Test Replay
Screenshots
Video
|
|
cypress/integration/dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-40-4
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Event data items correctly |
Test Replay
Screenshots
Video
|
|
cypress/integration/dimensions/data.cy.js • 2 flaky tests • e2e-chrome-parallel-41-4
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Data elements correctly |
Test Replay
Screenshots
Video
|
|
| Data dimension > displays Event data items correctly |
Test Replay
Screenshots
Video
|
|
cypress/integration/dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-42-4
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Indicators correctly |
Test Replay
Screenshots
Video
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-21001
Requires dhis2/analytics#1801
Description
Uses useDataOutputPeriodTypes from @dhis2/analytics (^29.3.0) to get server-configured period display labels on v43+.
Adds OVERRIDE_METADATA reducer action so server labels can overwrite the default translated ones.
Plugin waits for period type config before fetching data, then injects custom names into analytics responses.
Adds missing test mocks for the new hook.
Quality checklist
Add N/A to items that are not applicable.
After