Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
521 changes: 502 additions & 19 deletions cypress/integration/dimensions/period.cy.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2025-10-28T16:10:03.307Z\n"
"PO-Revision-Date: 2025-10-28T16:10:03.308Z\n"
"POT-Creation-Date: 2026-03-11T11:54:22.309Z\n"
"PO-Revision-Date: 2026-03-11T11:54:22.310Z\n"

msgid "All items"
msgstr "All items"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"typescript-eslint": "^8.35.0"
},
"dependencies": {
"@dhis2/analytics": "^29.1.0",
"@dhis2/analytics": "^29.3.2",
"@dhis2/app-runtime": "^3.14.1",
"@dhis2/app-service-datastore": "^1.0.0-beta.3",
"@dhis2/d2-i18n": "^1.1.0",
Expand Down
7 changes: 6 additions & 1 deletion src/actions/metadata.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { ADD_METADATA } from '../reducers/metadata.js'
import { ADD_METADATA, OVERRIDE_METADATA } from '../reducers/metadata.js'

export const acAddMetadata = (value) => ({
type: ADD_METADATA,
value,
})

export const acOverrideMetadata = (value) => ({
type: OVERRIDE_METADATA,
value,
})
10 changes: 9 additions & 1 deletion src/components/DimensionsPanel/Dialogs/DialogManager.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
WEEKLY,
WEEKLYWED,
WEEKLYTHU,
WEEKLYFRI,
WEEKLYSAT,
WEEKLYSUN,
BIWEEKLY,
Expand Down Expand Up @@ -85,7 +86,14 @@ const getExcludedPeriodTypes = (settings = {}) => {
types.push(DAILY)
}
if (settings['keyHideWeeklyPeriods']) {
types.push(WEEKLY, WEEKLYWED, WEEKLYTHU, WEEKLYSAT, WEEKLYSUN)
types.push(
WEEKLY,
WEEKLYWED,
WEEKLYTHU,
WEEKLYFRI,
WEEKLYSAT,
WEEKLYSUN
)
}
if (settings['keyHideBiWeeklyPeriods']) {
types.push(BIWEEKLY)
Expand Down
18 changes: 16 additions & 2 deletions src/components/Visualization/Visualization.jsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
import { useDataOutputPeriodTypes } from '@dhis2/analytics'
import debounce from 'lodash-es/debounce'
import PropTypes from 'prop-types'
import React, { Component, Fragment, useCallback, useMemo } from 'react'
import React, {
Component,
Fragment,
useCallback,
useEffect,
useMemo,
} from 'react'
import { useDispatch, useSelector } from 'react-redux'
import { tSetCurrentFromUi } from '../../actions/current.js'
import { acSetPluginLoading } from '../../actions/loader.js'
import { acAddMetadata } from '../../actions/metadata.js'
import { acAddMetadata, acOverrideMetadata } from '../../actions/metadata.js'
import {
acSetUiItems,
acSetUiDataSorting,
Expand Down Expand Up @@ -216,6 +223,13 @@ export const Visualization = (props) => {
)
const { setChart } = useChartContext()

const { enabledPeriodTypesData } = useDataOutputPeriodTypes()
useEffect(() => {
if (enabledPeriodTypesData?.metaData) {
dispatch(acOverrideMetadata(enabledPeriodTypesData.metaData))
}
}, [dispatch, enabledPeriodTypesData])

const visualization = useMemo(
() => getVisualizationWithFilteredOptionsByType(current),
[current]
Expand Down
8 changes: 8 additions & 0 deletions src/components/Visualization/__tests__/Visualization.spec.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ import { __setChart as setChart } from '../../ChartProvider.jsx' // eslint-disab
import { VisualizationPlugin } from '../../VisualizationPlugin/VisualizationPlugin.jsx'
import { Visualization } from '../Visualization.jsx'

jest.mock('@dhis2/analytics', () => ({
...jest.requireActual('@dhis2/analytics'),
useDataOutputPeriodTypes: () => ({
supportsEnabledPeriodTypes: false,
enabledPeriodTypesData: null,
}),
}))

jest.mock('../../ChartProvider.jsx', () => {
const setChart = jest.fn()
return {
Expand Down
25 changes: 24 additions & 1 deletion src/components/VisualizationPlugin/VisualizationPlugin.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
USER_ORG_UNIT_CHILDREN,
USER_ORG_UNIT_GRANDCHILDREN,
VIS_TYPE_SINGLE_VALUE,
useDataOutputPeriodTypes,
} from '@dhis2/analytics'
import { useConfig, useDataEngine } from '@dhis2/app-runtime'
import { Button, IconLegend24, Layer } from '@dhis2/ui'
Expand Down Expand Up @@ -79,6 +80,8 @@
const [size, setSize] = useState({ width: 0, height: 0 })
const resizeObserverRef = useRef(null)
const { baseUrl } = useConfig()
const { supportsEnabledPeriodTypes, enabledPeriodTypesData } =
useDataOutputPeriodTypes()

useEffect(() => {
resizeObserverRef.current = new window.ResizeObserver((entries) => {
Expand Down Expand Up @@ -278,6 +281,11 @@
}, [engine])

useEffect(() => {
// Wait for period type data to load when supported
if (supportsEnabledPeriodTypes && !enabledPeriodTypesData) {
return
}

setError(null)
setFetchResult(null)
setVisualization(null)
Expand Down Expand Up @@ -394,6 +402,15 @@

const legendSets = await doFetchLegendSets(legendSetIds)

if (enabledPeriodTypesData?.metaData) {
responses.forEach((response) => {
Object.assign(
response.metaData.items,
enabledPeriodTypesData.metaData
)
})
}

setFetchResult({
visualization: filteredVisualization,
legendSets,
Expand All @@ -407,7 +424,13 @@
.catch((error) => setError(error))
// since errors are rendered here, always call loading complete
.finally(() => onLoadingComplete())
}, [originalVisualization, filters, forDashboard])
}, [

Check warning on line 427 in src/components/VisualizationPlugin/VisualizationPlugin.jsx

View workflow job for this annotation

GitHub Actions / lint

React Hook useEffect has missing dependencies: 'baseUrl', 'doFetchData', 'doFetchLegendSets', and 'onLoadingComplete'. Either include them or remove the dependency array. If 'onLoadingComplete' changes too often, find the parent component that defines it and wrap that definition in useCallback
originalVisualization,
filters,
forDashboard,
supportsEnabledPeriodTypes,
enabledPeriodTypesData,
])

useEffect(() => {
if (fetchResult?.visualization && ouLevels) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ jest.mock('@dhis2/analytics', () => ({
id: '2nd-floor',
},
]),
useDataOutputPeriodTypes: () => ({
supportsEnabledPeriodTypes: false,
enabledPeriodTypesData: null,
}),
}))
global.ResizeObserver = jest.fn().mockImplementation(() => ({
observe: jest.fn(),
Expand Down
8 changes: 8 additions & 0 deletions src/reducers/metadata.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import getDefaultMetadata from '../modules/metadata.js'

export const ADD_METADATA = 'ADD_METADATA'
export const OVERRIDE_METADATA = 'OVERRIDE_METADATA'

export const DEFAULT_METADATA = getDefaultMetadata()

Expand All @@ -18,6 +19,13 @@ export default (state = DEFAULT_METADATA, action) => {
})
return result
}
case OVERRIDE_METADATA: {
const result = { ...state }
Object.entries(action.value).forEach(([key, value]) => {
result[key] = { ...result[key], ...value }
})
return result
}
default:
return state
}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1906,10 +1906,10 @@
classnames "^2.3.1"
prop-types "^15.7.2"

"@dhis2/analytics@^29.1.0":
version "29.1.0"
resolved "https://registry.yarnpkg.com/@dhis2/analytics/-/analytics-29.1.0.tgz#aaef83cab9edd3a59c891ee1e6a59a195059704b"
integrity sha512-A+c8O8uUc3omOa7PTBIyJsA1+9oIZw0AXZwSMdTYl6KZHiIiTkrLZvV8hLpMldKH4s7WMPeRiZxXt9F8ls57BA==
"@dhis2/analytics@^29.3.2":
version "29.3.2"
resolved "https://registry.yarnpkg.com/@dhis2/analytics/-/analytics-29.3.2.tgz#9cd598d5542a7c2885e58506059566d884476818"
integrity sha512-EKZ2uHxpaDsore+fYsswclTLhOgn2iJUDZ05hSGNg8LxW53dqECN2JWgFsG54FVeZ9+lYFJkrFxpsc7mcjdkfg==
dependencies:
"@dhis2/multi-calendar-dates" "^1.2.2"
"@dnd-kit/core" "^6.0.7"
Expand Down
Loading