Draft
Conversation
faridatulna
force-pushed
the
improvement/remove-unused-query
branch
from
62782ff to
89ea82c
Compare
faridatulna
commented
Apr 14, 2026
Member
Author
There was a problem hiding this comment.
Bang @habibimustafa, diaku kalau migration ini dijalankan kena error:
SQLSTATE[HY000]: General error: 1553 Cannot drop index 'idx_tag_subscriber': needed in a foreign key constraint (Connection: mysql, SQL: alter table
sendportal_tag_subscriberdrop indexidx_tag_subscriber)
Member
There was a problem hiding this comment.
ya benerin aja, nanti aku merge
Member
There was a problem hiding this comment.
kayaknya perlu 2 step itu
This reverts commit 401c122.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verdicts
$withCountadds overhead onfind(): The Tag model's$withCount = ['subscribers']appends a correlated count subquery even thoughupdate()never usessubscribers_count. The count is wasted here.$withCount = ['subscribers']on Tag model: Every query onTag(including thefind()call here) carries a correlated subquery counting subscribers. This is unnecessary overhead insidestore().