Skip to content

Improvement/remove-unused-query #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
faridatulna wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Improvement/remove-unused-query #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
401c122
feat: remove unused `$withCount` property from the `Tag` model.
faridatulna Apr 14, 2026
89ea82c
refactor: remove redundant index from `sendportal_tag_subscriber` mig…
faridatulna Apr 14, 2026
37589f6
Revert "feat: remove unused `$withCount` property from the `Tag` model."
faridatulna Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions database/migrations/2026_04_14_000002_drop_id_from_tag_subscriber.php
View file
Open in desktop
Copy link
Copy Markdown
Member Author

@faridatulna faridatulna Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bang @habibimustafa, diaku kalau migration ini dijalankan kena error:

SQLSTATE[HY000]: General error: 1553 Cannot drop index 'idx_tag_subscriber': needed in a foreign key constraint (Connection: mysql, SQL: alter table sendportal_tag_subscriber drop index idx_tag_subscriber)

Copy link
Copy Markdown
Member

@habibimustafa habibimustafa Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya benerin aja, nanti aku merge

Copy link
Copy Markdown
Member

@habibimustafa habibimustafa Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kayaknya perlu 2 step itu

Copy link
Copy Markdown
Member

@habibimustafa habibimustafa Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aku udah edit @faridatulna coba cek master

Copy link
Copy Markdown
Member Author

@faridatulna faridatulna Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bike @habibimustafa

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ public function up(): void
{
Schema::table('sendportal_tag_subscriber', function (Blueprint $table) {
$table->dropColumn('id');
$table->dropIndex('idx_tag_subscriber'); // redundant after PK change
$table->primary(['tag_id', 'subscriber_id']);
});
}
Expand All @@ -20,7 +19,6 @@ public function down(): void
Schema::table('sendportal_tag_subscriber', function (Blueprint $table) {
$table->dropPrimary(['tag_id', 'subscriber_id']);
$table->increments('id')->first();
$table->index(['tag_id', 'subscriber_id'], 'idx_tag_subscriber');
});
}
}