Move requirements file into seperate one#130
Conversation
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| compile_pip_requirements( |
There was a problem hiding this comment.
also how does it work when compiled requirements are not parsed by pip and passed as deps to any of the targets in this file?
Looks like adding only compile_pip_requirements with tag=manual has no impact, right?
There was a problem hiding this comment.
Yes it does seem that it has 0 impact as it's nowhere used in the dependencies.
And according to that it would be quiet useless.
But that isn't for me to fix, as I don't maintain this module and don't want to delete things that might be required later.
That's why I have only moved it to an appropriate location at the moment.
Having all reqs inside python_basics is breaking other modules. These requirements are only needed for testing, and should therefore be moved somewhere more appropriate where they do not break consumers of python_basics
9eee14a to
fee88dc
Compare
PiotrKorkus
left a comment
There was a problem hiding this comment.
lgtm, waiting for codeowners to approve
|
Pinging you two as you last worked on this repo and these files. This patch is needed to fix other repositories that rely on python_basics requirements file. As Piotr pointed out above, you are actually not using this requirements file in your tests, and purely rely on docs-as-code requirements to get all of the needed things. So please have a look, and let me know any questions that may arise. |
thanks @MaximilianSoerenPollak I did the cleanup here: #135 |

Having all reqs inside python_basics is breaking other modules. These requirements are only needed for testing, and should therefore be moved somewhere more appropriate where they do not break consumers of python_basics.