Skip to content

Move requirements file into seperate one #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramceb merged 3 commits into from
Mar 27, 2026
+533 −464
Merged

Move requirements file into seperate one #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dcf6a4
Move requirements file into seperate one
MaximilianSoerenPollak Mar 25, 2026
582b94f
Formatting
MaximilianSoerenPollak Mar 25, 2026
fee88dc
Add new files to reuse
MaximilianSoerenPollak Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions REUSE.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,17 @@ path = ["**/requirements_lock.txt"]
SPDX-FileCopyrightText = "Copyright (c) 2026 Contributors to the Eclipse Foundation"
SPDX-License-Identifier = "Apache-2.0"


[[annotations]]
path = ["cr_checker/resources/config.json",
"**/.bazelversion",
"coverage/tests/fixtures/symbol_report.json",
"python_basics/.bazelversion",
"python_basics/integration_tests/venv-with-extra-requirements/requirements.in",
"python_basics/requirements.in",
"python_basics/requirements.txt",
"bazel/rules/rules_score/test/requirements.in",
"bazel/rules/rules_score/test/requirements.txt"
]
SPDX-FileCopyrightText = "Copyright (c) 2026 Contributors to the Eclipse Foundation"
SPDX-License-Identifier = "Apache-2.0"
Expand Down
10 changes: 10 additions & 0 deletions bazel/rules/rules_score/test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# *******************************************************************************
load("@aspect_rules_py//py:defs.bzl", "py_binary")
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test")
load("@rules_python//python:pip.bzl", "compile_pip_requirements")
load(
"@score_tooling//bazel/rules/rules_score:rules_score.bzl",
"architectural_design",
Expand Down Expand Up @@ -448,3 +449,12 @@ toolchain(
toolchain_type = "@score_tooling//bazel/rules/rules_score:toolchain_type",
visibility = ["//visibility:public"],
)

compile_pip_requirements(
Copy link
Copy Markdown
Contributor

@PiotrKorkus PiotrKorkus Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also how does it work when compiled requirements are not parsed by pip and passed as deps to any of the targets in this file?

Looks like adding only compile_pip_requirements with tag=manual has no impact, right?

Copy link
Copy Markdown
Contributor Author

@MaximilianSoerenPollak MaximilianSoerenPollak Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does seem that it has 0 impact as it's nowhere used in the dependencies.

And according to that it would be quiet useless.
But that isn't for me to fix, as I don't maintain this module and don't want to delete things that might be required later.
That's why I have only moved it to an appropriate location at the moment.

name = "requirements",
src = "//:requirements.in",
requirements_txt = "//:requirements.txt",
tags = [
"manual",
],
)
8 changes: 8 additions & 0 deletions bazel/rules/rules_score/test/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
pytest
basedpyright
sphinx
sphinx-needs
sphinx-design
myst-parser
sphinxcontrib-plantuml
sphinx-rtd-theme
Loading
Loading