Runtime compiler RFC#1070 support by NullVoxPopuli · Pull Request #21076 · emberjs/ember.js

NullVoxPopuli · 2026-02-06T21:51:51Z

all of the allowed globals from RFC 1070 were not working with template().

This PR Fixes

NullVoxPopuli · 2026-02-06T21:52:42Z

packages/@ember/template-compiler/lib/plugins/allowed-globals.ts

+/**
+ * @private
+ *
+ * RFC: https://github.com/emberjs/rfcs/pull/1070


all of this copied from babel-plugin-ember-template-compilation

perhaps in a future release babel-plugin-ember-template-compilation could import this file (or remove the list entirely if we do this right)

github-actions · 2026-02-06T21:53:23Z

Estimated Asset Sizes

Diff

--- main/out.txt	2026-02-17 19:37:18.000000000 +0000
+++ pr/./pr-22261364053/out.txt	2026-02-21 17:47:12.000000000 +0000
@@ -1,13 +1,13 @@
 ╔═══════╤═══════════╤═══════════╗
 ║       │ Min       │ Gzip      ║
 ╟───────┼───────────┼───────────╢
-║ Total │ 351.99 KB │ 203.84 KB ║
+║ Total │ 352.52 KB │ 204.49 KB ║
 ╚═══════╧═══════════╧═══════════╝
 
 ╔══════════════════════╤═══════════╤═══════════╗
 ║ @ember/*             │ Min       │ Gzip      ║
 ╟──────────────────────┼───────────┼───────────╢
-║ Total                │ 313.39 KB │ 181.91 KB ║
+║ Total                │ 313.93 KB │ 182.55 KB ║
 ╟──────────────────────┼───────────┼───────────╢
 ║ -internals           │ 36.65 KB  │ 26.22 KB  ║
 ║ application          │ 13.23 KB  │ 8.05 KB   ║
@@ -30,7 +30,7 @@
 ║ service              │ 1 KB      │ 845 B     ║
 ║ template             │ 654 B     │ 541 B     ║
 ║ template-compilation │ 429 B     │ 366 B     ║
-║ template-compiler    │ 123.08 KB │ 59.45 KB  ║
+║ template-compiler    │ 123.62 KB │ 60.09 KB  ║
 ║ template-factory     │ 370 B     │ 374 B     ║
 ║ test                 │ 923 B     │ 627 B     ║
 ║ utils                │ 4.11 KB   │ 3.6 KB    ║

Details

This PR main

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.52 KB │ 204.49 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 313.93 KB │ 182.55 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 36.65 KB  │ 26.22 KB  ║
║ application          │ 13.23 KB  │ 8.05 KB   ║
║ array                │ 13.01 KB  │ 7.46 KB   ║
║ canary-features      │ 304 B     │ 389 B     ║
║ component            │ 2.05 KB   │ 1.64 KB   ║
║ controller           │ 1.96 KB   │ 1.41 KB   ║
║ debug                │ 11.69 KB  │ 8.12 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 1.08 KB   │ 811 B     ║
║ instrumentation      │ 2.43 KB   │ 1.79 KB   ║
║ modifier             │ 1.22 KB   │ 965 B     ║
║ object               │ 35.94 KB  │ 22.16 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 630 B     │ 487 B     ║
║ routing              │ 59.3 KB   │ 34.12 KB  ║
║ runloop              │ 2.36 KB   │ 1.5 KB    ║
║ service              │ 1 KB      │ 845 B     ║
║ template             │ 654 B     │ 541 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 123.62 KB │ 60.09 KB  ║
║ template-factory     │ 370 B     │ 374 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 4.11 KB   │ 3.6 KB    ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.6 KB  │ 21.94 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.77 KB  │ 1.39 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 608 B    ║
║ node            │ 175 B    │ 260 B    ║
║ opcode-compiler │ 1.11 KB  │ 894 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 301 B    ║
║ reference       │ 548 B    │ 531 B    ║
║ runtime         │ 10.32 KB │ 5.32 KB  ║
║ tracking        │ 1.34 KB  │ 1.16 KB  ║
║ util            │ 1.94 KB  │ 1.68 KB  ║
║ validator       │ 15.75 KB │ 6.96 KB  ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 351.99 KB │ 203.84 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 313.39 KB │ 181.91 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 36.65 KB  │ 26.22 KB  ║
║ application          │ 13.23 KB  │ 8.05 KB   ║
║ array                │ 13.01 KB  │ 7.46 KB   ║
║ canary-features      │ 304 B     │ 389 B     ║
║ component            │ 2.05 KB   │ 1.64 KB   ║
║ controller           │ 1.96 KB   │ 1.41 KB   ║
║ debug                │ 11.69 KB  │ 8.12 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 1.08 KB   │ 811 B     ║
║ instrumentation      │ 2.43 KB   │ 1.79 KB   ║
║ modifier             │ 1.22 KB   │ 965 B     ║
║ object               │ 35.94 KB  │ 22.16 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 630 B     │ 487 B     ║
║ routing              │ 59.3 KB   │ 34.12 KB  ║
║ runloop              │ 2.36 KB   │ 1.5 KB    ║
║ service              │ 1 KB      │ 845 B     ║
║ template             │ 654 B     │ 541 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 123.08 KB │ 59.45 KB  ║
║ template-factory     │ 370 B     │ 374 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 4.11 KB   │ 3.6 KB    ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.6 KB  │ 21.94 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.77 KB  │ 1.39 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 608 B    ║
║ node            │ 175 B    │ 260 B    ║
║ opcode-compiler │ 1.11 KB  │ 894 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 301 B    ║
║ reference       │ 548 B    │ 531 B    ║
║ runtime         │ 10.32 KB │ 5.32 KB  ║
║ tracking        │ 1.34 KB  │ 1.16 KB  ║
║ util            │ 1.94 KB  │ 1.68 KB  ║
║ validator       │ 15.75 KB │ 6.96 KB  ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝

…al-mode

…e allowed globals can be accessed

ef4 · 2026-02-20T19:56:48Z

packages/@ember/template-compiler/lib/compile-options.ts

-    options.lexicalScope = (variable: string) => variable in scope;
+    options.lexicalScope = (variable: string) => {
+      if (ALLOWED_GLOBALS.has(variable)) {
+        return variable in globalThis;


I think we should remove this, skipping over the user's real scope means their own local choices don't take priority over the globals.

confirm this isn't needed - tyty

Removed check for ALLOWED_GLOBALS in lexicalScope function.

NullVoxPopuli · 2026-02-21T17:07:39Z

...r/-internals/glimmer/tests/integration/components/runtime-template-compiler-explicit-test.ts

+        this.prototype[`@test Can use ${globalName}`] = async function () {
+          await this.renderComponentModule(() => {
+            return template(`{{if ${globalName} "exists"}}`, {
+              scope: () => ({}),


a fatal flaw found here, prompted by @ef4's question in the explricit scope lexicalScope check -- this scope bag is empty! it should include the global 🙈

Update test to pass global variables into scope for explicit runtime template compiler tests.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>

Fix trailing whitespace in runtime template compiler test

Simplify lexicalScope function by removing global check

NullVoxPopuli commented Feb 6, 2026

View reviewed changes

NullVoxPopuli force-pushed the nvp/add-tests-for-RFC-1070 branch from 3a5609a to f783445 Compare February 11, 2026 06:19

NullVoxPopuli marked this pull request as ready for review February 11, 2026 07:14

NullVoxPopuli force-pushed the nvp/add-tests-for-RFC-1070 branch 2 times, most recently from 4e55c60 to a02d1a7 Compare February 11, 2026 09:26

NullVoxPopuli added 2 commits February 11, 2026 09:58

Repro for RFC#1070 - none of the default globals are accessible in ev…

d746e14

…al-mode

Implement RFC#1070 via telling the runtime lexicalScope check that th…

a61c6f9

…e allowed globals can be accessed

NullVoxPopuli force-pushed the nvp/add-tests-for-RFC-1070 branch from a02d1a7 to a61c6f9 Compare February 11, 2026 14:58

NullVoxPopuli requested review from ef4 and kategengler February 11, 2026 17:17

ef4 reviewed Feb 20, 2026

View reviewed changes

Simplify lexicalScope function by removing global check

a7e08d0

Removed check for ALLOWED_GLOBALS in lexicalScope function.

NullVoxPopuli mentioned this pull request Feb 21, 2026

Simplify lexicalScope function by removing global check #21110

Merged

NullVoxPopuli commented Feb 21, 2026

View reviewed changes

NullVoxPopuli and others added 6 commits February 21, 2026 12:11

Pass globals to scope in runtime template tests (explicit)

cbb4278

Update test to pass global variables into scope for explicit runtime template compiler tests.

formatting

841c5fb

Initial plan

7ea1756

lint: fix trailing whitespace

1f2f722

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>

Merge pull request #21111 from emberjs/copilot/sub-pr-21110

5e1fd29

Fix trailing whitespace in runtime template compiler test

Merge pull request #21110 from emberjs/NullVoxPopuli-patch-1

d72563d

Simplify lexicalScope function by removing global check

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Runtime compiler RFC#1070 support#21076

Runtime compiler RFC#1070 support#21076
NullVoxPopuli wants to merge 9 commits intomainfrom
nvp/add-tests-for-RFC-1070

NullVoxPopuli commented Feb 6, 2026 •

edited

Loading

Uh oh!

NullVoxPopuli Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

ef4 Feb 20, 2026

Uh oh!

NullVoxPopuli Feb 21, 2026

Uh oh!

NullVoxPopuli Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

NullVoxPopuli commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ef4 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NullVoxPopuli commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading