Assert when glDrawElements cannot draw anything because of missing vertex bounds#26525
Open
paradust7 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Assert when glDrawElements cannot draw anything because of missing vertex bounds#26525paradust7 wants to merge 1 commit intoemscripten-core:mainfrom
paradust7 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Mar 23, 2026
| if (!cb.clientside || !cb.enabled) continue; | ||
|
|
||
| #if ASSERTIONS | ||
| assert(count || !GLctx.currentElementArrayBufferBinding, 'must use array buffers when using element buffer'); |
Collaborator
There was a problem hiding this comment.
Does this assert belong here inside this for loop? Could it not go outside the loop?
Collaborator
There was a problem hiding this comment.
Should this be !count || !GLctx.currentElementArrayBufferBinding ? (i.e. I'm not sure what the count || part is doing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with FULL_ES2, glDrawElements cannot handle the case where the indices are in a buffer but the vertices are client-side. Nothing will be drawn in this case. Add an assertion to make this situation visible when debugging.
Fixes #26460