Fix arithmetic overflow in query_stats collector#548
Merged
erikdarlingdata merged 2 commits intodevfrom Mar 13, 2026
Merged
Conversation
DMV sys.dm_exec_query_stats returns min_dop, max_dop, and thread columns as bigint, but our temp table and permanent table used smallint/integer — causing overflow on INSERT. Widened to match actual DMV types: - min_dop, max_dop: smallint -> bigint - min/max_reserved_threads, min/max_used_threads: integer -> bigint Includes upgrade script for existing 2.2.0 installations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The publish/ directory is gitignored; the type fix was already applied to install/02_create_tables.sql (the source of truth). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect.query_statscollector fails with "Arithmetic overflow error converting expression to data type smallint" becausemin_dop/max_doparesmallintin our schema butbigintinsys.dm_exec_query_statsmin/max_reserved_threadsandmin/max_used_threadsfromintegertobigintto match the DMVChanges
collect.query_statsfrom smallint/integer to bigint#query_stats_stagingtemp tableTest plan
bigintcolumnsCloses #547
🤖 Generated with Claude Code