Fix storage emulator crash on invalid JWT and add unit tests

[kevmoo]

Description

The emulator crashes when it gets a malformed or missing auth token

Scenarios Tested

The auth code returns null (instead of crashing) when the token is missing or invalid

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of the storage emulator by addressing a critical crash scenario related to authentication token processing. By gracefully handling invalid or missing JWTs, the emulator becomes more stable and reliable, preventing unexpected failures during development and testing. The accompanying unit tests validate this improved behavior, ensuring the fix is effective and maintainable.

Highlights

• Emulator Stability: Implemented a fix in the storage emulator to prevent crashes when processing malformed or missing JSON Web Tokens (JWTs), ensuring it returns 'null' instead.
• Unit Testing: Added comprehensive unit tests for the 'createAuthExpressionValue' function, covering scenarios with missing, invalid, and valid authentication tokens to ensure correct behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a crash in the storage emulator when handling invalid JWTs by adding a null check after decoding the token. The addition of unit tests is a great way to ensure this fix is robust and prevents future regressions. My review includes one suggestion to improve the type safety of the implementation, aligning it better with the repository's style guide by removing an as any type assertion.

[kevmoo]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively addresses a crash in the storage emulator when handling invalid JWTs by adding a check for malformed tokens. The inclusion of unit tests is a great addition to ensure this fix is robust and prevents future regressions.

I've provided a couple of suggestions to improve code readability and maintainability by reducing nesting and code duplication, in line with the repository's best practices.

[kevmoo]

The CI failure is unrelated - fixed in #10141