ref(build): release Docker image to GHCR via Craft

[aldy505]

This is an ongoing effort to simplify the release process to not rely on the hacky GitHub Actions script that copies the Docker image after a release was created.

Part of getsentry/self-hosted#4123

REF SELF-78

[markstory]

Does craft read the output of this script?

[aldy505]

Nope. Craft only need this script to run, so the changelog will be properly generated.

[markstory]

Looks good, but there is an image build permission issue.

[sentry]

Bug: The bump-version.sh script is a no-op and does not update the project version. This will cause the Craft release process to fail because there are no changes to commit.
_{Severity: HIGH}

Suggested Fix

Modify bump-version.sh to update the version string in Cargo.toml and any other relevant files. For example, use a command-line tool like sed to find and replace the old version string with the new one provided to the script.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: scripts/bump-version.sh#L1-L17

Potential issue: The `bump-version.sh` script is intended for use by the Craft release
tool to automate version bumping. However, the script is currently a no-op; it only
prints the old and new versions without modifying any files. The Craft release process
requires this script to update the version in project files, such as `Cargo.toml`.
Because no files are changed, the subsequent step in the release workflow, which commits
the version bump, will fail as there are no changes to commit. This will block the
entire automated release process.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[aldy505]

@BYK can you remind me again, do we need this bump-version script?

[BYK]

@aldy505 yes, unless you explicitly disable it in craft.yml

[aldy505]

@markstory when you're back, feel free to merge this :)