Skip to content

ref(build): release Docker image to GHCR via Craft #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstory merged 5 commits into from
Mar 18, 2026
Merged

ref(build): release Docker image to GHCR via Craft #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cc72cf
ref(build): release Docker image to GHCR via Craft
aldy505 Dec 25, 2025
15e2435
build: add no-op bump-version.sh as Craft wants it
aldy505 Dec 25, 2025
3d43680
Merge branch 'main' into build/release-ghcr-via-craft
aldy505 Feb 1, 2026
f7da04b
Fix lint error
markstory Feb 4, 2026
7c45c2f
Merge remote-tracking branch 'origin/main' into build/release-ghcr-vi…
aldy505 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,26 @@
minVersion: "2.19.0"
changelogPolicy: auto
changelog:
policy: auto
artifactProvider:
name: none
statusProvider:
name: github
config:
contexts:
- 'build-arm64'
- 'build-amd64'
- 'assemble-taskbroker-image'
- 'build-arm64'
- 'build-amd64'
- 'assemble-taskbroker-image'
preReleaseCommand: ""
targets:
- name: github
- id: release
name: docker
source: ghcr.io/getsentry/taskbroker
target: ghcr.io/getsentry/taskbroker
- id: latest
name: docker
source: ghcr.io/getsentry/taskbroker
target: ghcr.io/getsentry/taskbroker
targetFormat: '{{{target}}}:latest'
- name: github
versioning:
policy: calver
28 changes: 0 additions & 28 deletions .github/workflows/release-ghcr-version-tag.yml
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions scripts/bump-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/bash
set -euo pipefail

if [ "$(uname -s)" != "Linux" ]; then
echo "This script can only be run on Linux!"
echo "Please use the GitHub Action instead."
exit 1
fi

SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
cd $SCRIPT_DIR/..

OLD_VERSION="${1}"
NEW_VERSION="${2}"

echo "Current version: ${OLD_VERSION}"
echo "Bumping version: ${NEW_VERSION}"
Comment on lines +7 to +17
Copy link

@sentry sentry bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The bump-version.sh script is a no-op and does not update the project version. This will cause the Craft release process to fail because there are no changes to commit.
Severity: HIGH

Suggested Fix

Modify bump-version.sh to update the version string in Cargo.toml and any other relevant files. For example, use a command-line tool like sed to find and replace the old version string with the new one provided to the script.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: scripts/bump-version.sh#L1-L17

Potential issue: The `bump-version.sh` script is intended for use by the Craft release
tool to automate version bumping. However, the script is currently a no-op; it only
prints the old and new versions without modifying any files. The Craft release process
requires this script to update the version in project files, such as `Cargo.toml`.
Because no files are changed, the subsequent step in the release workflow, which commits
the version bump, will fail as there are no changes to commit. This will block the
entire automated release process.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Collaborator Author

@aldy505 aldy505 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BYK can you remind me again, do we need this bump-version script?

Copy link
Member

@BYK BYK Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldy505 yes, unless you explicitly disable it in craft.yml

Loading