[WIP] Rewrite changes and review tests from pull request 19591#19609
[WIP] Rewrite changes and review tests from pull request 19591#19609
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the setup-cli installer and its lightweight shell tests to support version-aware gh extension install and correct the reported installed version.
Changes:
- Add conditional version pinning when installing via
gh extension install(pin whenVERSION != latest). - Fix
installed_versionoutput to reflect the detected installed extension version for theghinstall path. - Update
install_test.shto correct test numbering and validate version pinning logic instead of release validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| actions/setup-cli/install.sh | Adds version-aware gh extension install branching and fixes the installed_version output for the gh install path. |
| actions/setup-cli/install_test.sh | Renumbers tests and replaces the release-validation grep with a version-pinning grep. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot review the changes from a security and portability point of view |
Security and portability review of the changes: Security ✅
Portability ✅
No issues found — the implementation is both secure and appropriately portable for a bash script. |
install.sh: replacegh extension installwith version-aware branching (no eval, fixinstalled_versionoutput bug)install_test.sh: correct test number labels, replacetest_release_validationwithtest_version_pinning💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.