Skip to content

[WIP] Rewrite changes and review tests from pull request 19591 #19609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Mar 4, 2026
+24 −13
Merged

[WIP] Rewrite changes and review tests from pull request 19591 #19609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e6156
Initial plan
Copilot Mar 4, 2026
19d0694
fix: install correct version in action (#19591)
Copilot Mar 4, 2026
c8451eb
Merge branch 'main' into copilot/rewrite-changes-and-review-tests
pelikhan Mar 4, 2026
0926e5a
Update install.sh
pelikhan Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions actions/setup-cli/install.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 12 additions & 10 deletions actions/setup-cli/install_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ test_executable() {
# Test 3: Verify INPUT_VERSION support
test_input_version() {
echo ""
echo "Test 4: Verify INPUT_VERSION environment variable support"
echo "Test 3: Verify INPUT_VERSION environment variable support"

# Check if script references INPUT_VERSION
if grep -q "INPUT_VERSION" "$SCRIPT_PATH"; then
Expand All @@ -69,10 +69,10 @@ test_input_version() {
fi
}

# Test 5: Verify gh extension install attempt
# Test 4: Verify gh extension install attempt
test_gh_install() {
echo ""
echo "Test 5: Verify gh extension install logic"
echo "Test 4: Verify gh extension install logic"

# Check if script has gh extension install logic
if grep -q "gh extension install" "$SCRIPT_PATH"; then
Expand All @@ -82,15 +82,17 @@ test_gh_install() {
fi
}

# Test 5: Verify release validation
test_release_validation() {
# Test 5: Verify version pinning support
test_version_pinning() {
echo ""
echo "Test 5: Verify release validation"
echo "Test 5: Verify version pinning for gh extension install"

if grep -q "Validating release.*exists" "$SCRIPT_PATH"; then
print_result "Script includes release validation" "PASS"
# Check if script uses --pin flag with $VERSION variable AND checks VERSION != "latest"
if grep -q -- '--pin.*\$VERSION' "$SCRIPT_PATH" && \
grep -q '"\$VERSION" != "latest"' "$SCRIPT_PATH"; then
print_result "Script supports version pinning with correct variable usage" "PASS"
else
print_result "Script missing release validation" "FAIL"
print_result "Script missing proper version pinning support (must use --pin with \$VERSION and check VERSION != latest)" "FAIL"
fi
}

Expand All @@ -116,7 +118,7 @@ test_script_syntax
test_executable
test_input_version
test_gh_install
test_release_validation
test_version_pinning
test_checksum_validation

# Summary
Expand Down
Loading