Skip to content

chore(ci): update gcloud sdk version #15938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scotthart wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

chore(ci): update gcloud sdk version #15938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3ec95
chore(ci): update gcloud sdk version
scotthart Feb 5, 2026
a04da2d
revert upgrade
scotthart Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/cloudbuild/builds/lib/integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,11 @@ function integration::bazel_with_emulators() {

io::log_h2 "Running Storage integration tests (with emulator)"
"google/cloud/storage/ci/${EMULATOR_SCRIPT}" \
bazel "${verb}" "${args[@]}" --test_tag_filters="integration-test,-ud-only"
bazel "${verb}" "${args[@]}" --cache_test_results=no --test_tag_filters="integration-test,-ud-only"

io::log_h2 "Running Spanner integration tests (with emulator)"
"google/cloud/spanner/ci/${EMULATOR_SCRIPT}" \
bazel "${verb}" "${args[@]}" --test_tag_filters="integration-test,-ud-only"
bazel "${verb}" "${args[@]}" --cache_test_results=no --test_tag_filters="integration-test,-ud-only"
Comment on lines +211 to +215
Copy link

@gemini-code-assist gemini-code-assist bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The flag --cache_test_results=no has been added for Storage and Spanner tests, but not for the other emulator-based tests (Pub/Sub, Bigtable, REST). This introduces an inconsistency. For better maintainability, this flag should either be applied to all similar test runs in this function, or a comment should be added explaining why it's specific to Storage and Spanner.


io::log_h2 "Running Bigtable integration tests (with emulator)"
"google/cloud/bigtable/ci/${EMULATOR_SCRIPT}" \
Expand Down