Open
Conversation
jackwrfuller
force-pushed
the
drupal-test-traits
branch
from
695ece8 to
c1f396b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Internal ticket: GOVCMS-14463
Fixes phpunit testing by making all the testing dependencies
--devdependencies that only get included in the test image (not thecliimage).This also avoids having to
composer installthese deps at the scaffold layer, since they are baked into the test image.It also adds support for Drupal Test Traits, as requested by govCMS/GovCMS#1481
The exact dep version probably need a review, but this is a good starting point.
After this change is merged, we will need to merge govCMS/scaffold#142 so that new projects can run tests out of the box.