fix: make RC logs visible in Windows GitHub Actions [HZ-5386]

[ihsandemir]

Summary

• Redirect Windows remote controller stdout/stderr to rc_stdout.log (RC runs in a separate minimized console window via start /MIN, so output is lost in CI)
• Print RC log contents after tests complete in both success and failure paths of test-windows.bat

Test plan

• Verify Windows CI workflow runs successfully
• Confirm RC logs appear in GitHub Actions output after test completion
• Verify RC startup failure path also prints logs

[JackPGreen]

The change is fine in isolation but a bit confused about how it fits in with the other platforms.

Specifically, the Windows script starts RC and echos to a file, but the Unix one just starts and prints to console:

hazelcast-cpp-client/scripts/start-rc.sh

Lines 127 to 132 in 6a064f9

	java -cp ${CLASSPATH} \
	-Dhazelcast.enterprise.license.key=${HAZELCAST_ENTERPRISE_KEY} \
	-Dhazelcast.phone.home.enabled=false \
	$MODULE_ARGUMENTS \
	com.hazelcast.remotecontroller.Main --use-simple-server &
	rcPid=$!

[ihsandemir]

The change is fine in isolation but a bit confused about how it fits in with the other platforms.

Specifically, the Windows script starts RC and echos to a file, but the Unix one just starts and prints to console:

hazelcast-cpp-client/scripts/start-rc.sh

Lines 127 to 132 in 6a064f9

	java -cp ${CLASSPATH} \
	-Dhazelcast.enterprise.license.key=${HAZELCAST_ENTERPRISE_KEY} \
	-Dhazelcast.phone.home.enabled=false \
	$MODULE_ARGUMENTS \
	com.hazelcast.remotecontroller.Main --use-simple-server &
	rcPid=$!

On Linux/MacOS, start-rc.sh runs the RC java process with & (background), and its stdout/stderr are inherited by the parent shell - so RC logs naturally appear in GitHub Actions output. On Windows, start-rc.bat uses start "hazelcast-remote-controller" /MIN cmd /c "java ..." which launches RC in a separate minimized console window. In GitHub Actions, this output is completely lost - making it impossible to debug RC startup failures or see RC-side errors during test runs.

[JackPGreen]

The change is fine in isolation but a bit confused about how it fits in with the other platforms.
Specifically, the Windows script starts RC and echos to a file, but the Unix one just starts and prints to console:

hazelcast-cpp-client/scripts/start-rc.sh

Lines 127 to 132 in 6a064f9

	java -cp ${CLASSPATH} \
	-Dhazelcast.enterprise.license.key=${HAZELCAST_ENTERPRISE_KEY} \
	-Dhazelcast.phone.home.enabled=false \
	$MODULE_ARGUMENTS \
	com.hazelcast.remotecontroller.Main --use-simple-server &
	rcPid=$!

On Linux/MacOS, start-rc.sh runs the RC java process with & (background), and its stdout/stderr are inherited by the parent shell - so RC logs naturally appear in GitHub Actions output. On Windows, start-rc.bat uses start "hazelcast-remote-controller" /MIN cmd /c "java ..." which launches RC in a separate minimized console window. In GitHub Actions, this output is completely lost - making it impossible to debug RC startup failures or see RC-side errors during test runs.

Ok - that makes sense. Your suggested approach works, but is it possible to use the same background-task-execution implementation on Windows?

A quick test shows:
start /b ping github.com -t

Pipes the output into the original window while allowing it to proceed.

[ihsandemir]

The change is fine in isolation but a bit confused about how it fits in with the other platforms.
Specifically, the Windows script starts RC and echos to a file, but the Unix one just starts and prints to console:

hazelcast-cpp-client/scripts/start-rc.sh

Lines 127 to 132 in 6a064f9

	java -cp ${CLASSPATH} \
	-Dhazelcast.enterprise.license.key=${HAZELCAST_ENTERPRISE_KEY} \
	-Dhazelcast.phone.home.enabled=false \
	$MODULE_ARGUMENTS \
	com.hazelcast.remotecontroller.Main --use-simple-server &
	rcPid=$!

On Linux/MacOS, start-rc.sh runs the RC java process with & (background), and its stdout/stderr are inherited by the parent shell - so RC logs naturally appear in GitHub Actions output. On Windows, start-rc.bat uses start "hazelcast-remote-controller" /MIN cmd /c "java ..." which launches RC in a separate minimized console window. In GitHub Actions, this output is completely lost - making it impossible to debug RC startup failures or see RC-side errors during test runs.

Ok - that makes sense. Your suggested approach works, but is it possible to use the same background-task-execution implementation on Windows?

A quick test shows: start /b ping github.com -t

Pipes the output into the original window while allowing it to proceed.

let me try this.
Trying the fix at #1414

[ihsandemir]

@JackPGreen Changes based on your suggestion. It seems to work that way as well. Will close this PR and merge the new PR #1414

[ihsandemir]

replaced by #1414