Skip to content

fix: make RC logs visible in Windows GitHub Actions [HZ-5387]#1414

Merged
ihsandemir merged 1 commit intomasterfrom
fix/windows-rc-logs-v2
Mar 16, 2026
Merged

fix: make RC logs visible in Windows GitHub Actions [HZ-5387]#1414
ihsandemir merged 1 commit intomasterfrom
fix/windows-rc-logs-v2

Conversation

@ihsandemir
Copy link
Collaborator

@ihsandemir ihsandemir commented Mar 16, 2026

Use start /B instead of start /MIN cmd /c so RC stdout/stderr appear in the same console — visible in CI in real-time. Replace taskkill window-title filter with wmic command-line match since start /B does not create a titled window.

replaces #1413

Use `start /B` instead of `start /MIN cmd /c` so RC stdout/stderr
appear in the same console — visible in CI in real-time. Replace
taskkill window-title filter with wmic command-line match since
`start /B` does not create a titled window.
@ihsandemir ihsandemir self-assigned this Mar 16, 2026
@ihsandemir ihsandemir modified the milestone: 5.7.0 Mar 16, 2026
@ihsandemir ihsandemir marked this pull request as ready for review March 16, 2026 13:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the move to wmic for graceful shutdowns, or wildcards?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean wildcards?

We are using wmic for all paths success or fail to close the outstanding background process.

@ihsandemir ihsandemir changed the title fix: make RC logs visible in Windows GitHub Actions fix: make RC logs visible in Windows GitHub Actions [HZ-5387] Mar 16, 2026
@ihsandemir ihsandemir merged commit 301484b into master Mar 16, 2026
31 checks passed
@ihsandemir ihsandemir deleted the fix/windows-rc-logs-v2 branch March 16, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants