Skip to content

fix: make RC logs visible in Windows GitHub Actions [HZ-5387] #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihsandemir merged 1 commit into from
Mar 16, 2026
Merged

fix: make RC logs visible in Windows GitHub Actions [HZ-5387] #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/start-rc.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ set CLASSPATH="hazelcast-remote-controller-%HAZELCAST_RC_VERSION%.jar;hazelcast-
echo "Starting Remote Controller ... enterprise ...Using classpath: %CLASSPATH%"

echo "Starting hazelcast-remote-controller"
start "hazelcast-remote-controller" /MIN cmd /c "java -Dhazelcast.enterprise.license.key=%HAZELCAST_ENTERPRISE_KEY% -Dhazelcast.phone.home.enabled=false -cp %CLASSPATH% com.hazelcast.remotecontroller.Main --use-simple-server"
start /B java -Dhazelcast.enterprise.license.key=%HAZELCAST_ENTERPRISE_KEY% -Dhazelcast.phone.home.enabled=false -cp %CLASSPATH% com.hazelcast.remotecontroller.Main --use-simple-server
4 changes: 2 additions & 2 deletions scripts/test-windows.bat
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@JackPGreen JackPGreen Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the move to wmic for graceful shutdowns, or wildcards?

Copy link
Copy Markdown
Collaborator Author

@ihsandemir ihsandemir Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean wildcards?

We are using wmic for all paths success or fail to close the outstanding background process.

Copy link
Copy Markdown
Contributor

@JackPGreen JackPGreen Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late to bring this up, but wmic is deprecated.

Copy link
Copy Markdown
Collaborator Author

@ihsandemir ihsandemir Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1417

Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ echo "Waiting for the test server to start. Timeout: %timeout% seconds"

:server_failed_to_start
echo "The test server did not start in %RC_START_TIMEOUT_IN_SECS% seconds. Test FAILED."
call taskkill /F /FI "WINDOWTITLE eq hazelcast-remote-controller"
wmic process where "commandline like '%%com.hazelcast.remotecontroller.Main%%'" call terminate >nul 2>&1
exit /b 1

:server_started
Expand All @@ -63,6 +63,6 @@ echo %TEST_EXECUTABLE%
%TEST_EXECUTABLE% --gtest_output="xml:CPP_Client_Test_Report.xml"
set result=%errorlevel%

taskkill /T /F /FI "WINDOWTITLE eq hazelcast-remote-controller"
wmic process where "commandline like '%%com.hazelcast.remotecontroller.Main%%'" call terminate >nul 2>&1

exit /b %result%
Loading