fix: correct NVIDIA CUDA queue guard in run_opencl_fft#271
Merged
inducer merged 1 commit intoinducer:mainfrom Mar 17, 2026
Merged
fix: correct NVIDIA CUDA queue guard in run_opencl_fft#271inducer merged 1 commit intoinducer:mainfrom
inducer merged 1 commit intoinducer:mainfrom
Conversation
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #270.
Summary
run_opencl_fftfor the NVIDIA CUDA pathwait_forcontains events from a different command queueWhy
The previous condition used
if not evt.command_queue != queue, which is logically equivalent toevt.command_queue == queue. That raised on the safe same-queue case and failed to reject different queues.Validation
volumentialon NVIDIA CUDA before the fix (RuntimeError: Different queues not supported with NVIDIA CUDA)test/test_volume_fmm.py::test_volume_fmm_laplacepasses for NVIDIA CUDA onipa