Skip to content

fix: correct NVIDIA CUDA queue guard in run_opencl_fft #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 1 commit into from
Mar 17, 2026
Merged

fix: correct NVIDIA CUDA queue guard in run_opencl_fft #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sumpy/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@
app, backend = fft_app

if backend == FFTBackend.loopy:
evt, output_vec = app(actx.queue, y=input_vec, wait_for=wait_for)

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine with Loopy FFT 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine with Loopy FFT 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine with Loopy FFT 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.

Check warning on line 1021 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine with Loopy FFT 

TranslationUnit.__call__ is uncached as of 2025, meaning it will incur possibly substantial compilation cost with every invocation. Use TranslationUnit.executor to obtain an object that holds longer-lived caches.
return (evt, output_vec["x"])
elif backend == FFTBackend.pyvkfft:
if wait_for is None:
Expand All @@ -1032,7 +1032,7 @@
# Not passing wait_for will wait for all events queued before
# and therefore correctness is preserved if it's the same queue
for evt in wait_for:
if not evt.command_queue != queue:
if evt.command_queue != queue:
raise RuntimeError(
"Different queues not supported with NVIDIA CUDA")
start_evt = cl.enqueue_marker(queue)
Expand All @@ -1043,7 +1043,7 @@
raise RuntimeError("inplace fft is not supported")
else:
# FIXME: All very imperative. FFT functionality should move into the actx?
output_vec = actx.np.empty_like(input_vec) # pyright: ignore[reportUnknownMemberType, reportAttributeAccessIssue]

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

Check warning on line 1046 in sumpy/tools.py

View workflow job for this annotation

GitHub Actions / Conda Pytest Symengine 

PyOpenCLArrayContext.np.empty_like is deprecated and will stop working in 2023. Prefer actx.np.zeros_like instead.

meth = app.ifft if inverse else app.fft

Expand Down
Loading