Skip to content

Adds SimpleShading Annotators#4541

Merged
kellyguo11 merged 3 commits intoisaac-sim:developfrom
matthewtrepte:mtrepte/add_simple_shading
Feb 11, 2026
Merged

Adds SimpleShading Annotators#4541
kellyguo11 merged 3 commits intoisaac-sim:developfrom
matthewtrepte:mtrepte/add_simple_shading

Conversation

@matthewtrepte
Copy link
Copy Markdown
Contributor

Description

Add support for new SimpleShading annotators to camera and tiled cameras
Expand unit tests to cover new annotators
Expand cartpole envs to include new annotators

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 5, 2026

Too many files changed for review. (390 files found, 100 file limit)

@matthewtrepte matthewtrepte changed the base branch from main to develop February 5, 2026 02:20
@github-actions github-actions Bot added documentation Improvements or additions to documentation asset New asset feature or request isaac-sim Related to Isaac Sim team isaac-mimic Related to Isaac Mimic team infrastructure labels Feb 5, 2026
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Feb 5, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll also need to extend this list. perhaps a better way to do this is to just check if the regular RGB/RGBA annotators are requested and set this flag to True if no RGB/RGBA annotators are needed.

@kellyguo11 kellyguo11 changed the title Add SimpleShading Annotators Adds SimpleShading Annotators Feb 10, 2026
@kellyguo11 kellyguo11 merged commit e7c04b9 into isaac-sim:develop Feb 11, 2026
7 of 9 checks passed
daniela-hase pushed a commit to daniela-hase/IsaacLab that referenced this pull request Mar 30, 2026
# Description

<!--
Thank you for your interest in sending a pull request. Please make sure
to check the contribution guidelines.

Link:
https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html

💡 Please try to keep PRs small and focused. Large PRs are harder to
review and merge.
-->

Add support for new SimpleShading annotators to camera and tiled cameras
Expand unit tests to cover new annotators
Expand cartpole envs to include new annotators


<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [ ] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asset New asset feature or request documentation Improvements or additions to documentation infrastructure isaac-lab Related to Isaac Lab team isaac-mimic Related to Isaac Mimic team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants