Skip to content

feat: add server id to login command#1529

Open
tim-goto wants to merge 1 commit intojfrog:masterfrom
tim-goto:feature/tharing/server-id-for-login-command
Open

feat: add server id to login command#1529
tim-goto wants to merge 1 commit intojfrog:masterfrom
tim-goto:feature/tharing/server-id-for-login-command

Conversation

@tim-goto
Copy link
Copy Markdown

this allows scripting the login without the modal prompt

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the master branch.
  • I used gofmt for formatting the code before submitting the pull request.

this allows scripting the login without the modal prompt
@tim-goto
Copy link
Copy Markdown
Author

@naveenku-jfrog can you also please take a look here? Our TSM is Douglas Hemsworth. Thanks!

if lc.serverId != "" {
return existingServerLogin(lc.serverId)
}
configurations, err := config.GetAllServersConfigs()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants