Skip to content

feat: add server id to login command #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tim-goto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add server id to login command #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions general/login/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,22 @@ const (
)

type LoginCommand struct {
serverId string
}

func NewLoginCommand() *LoginCommand {
return &LoginCommand{}
}

func (lc *LoginCommand) SetServerId(serverId string) *LoginCommand {
lc.serverId = serverId
return lc
}

func (lc *LoginCommand) Run() error {
if lc.serverId != "" {
return existingServerLogin(lc.serverId)
}
configurations, err := config.GetAllServersConfigs()
Copy link
Copy Markdown
Contributor

@RemiBou RemiBou Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

Copy link
Copy Markdown
Author

@tim-goto tim-goto Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking the time to review my pr, I have added tests for the lines that I added. There were no tests at all for that part of the code, that's why I didn't add any tests

if err != nil {
return err
Expand Down
35 changes: 35 additions & 0 deletions general/login/login_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package login

import (
"testing"

"github.com/jfrog/jfrog-cli-core/v2/utils/config"
utilsTests "github.com/jfrog/jfrog-cli-core/v2/utils/tests"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestSetServerId(t *testing.T) {
lc := NewLoginCommand()
result := lc.SetServerId("my-server")
assert.Equal(t, "my-server", lc.serverId)
// Verify fluent API returns the same instance
assert.Same(t, lc, result)
}

func TestRunWithNonExistentServerId(t *testing.T) {
cleanUp, err := utilsTests.SetJfrogHome()
require.NoError(t, err)
defer cleanUp()

// At least one server must exist so GetConfig actually looks up by ID
err = config.SaveServersConf([]*config.ServerDetails{
{ServerId: "other-server", Url: "https://example.jfrog.io/"},
})
require.NoError(t, err)

lc := NewLoginCommand().SetServerId("non-existent-server")
err = lc.Run()
assert.ErrorContains(t, err, "non-existent-server")
}

Loading