Refactor transfer configuration error handling and logging#1531
Open
haizafrog wants to merge 2 commits intojfrog:masterfrom
Open
Refactor transfer configuration error handling and logging#1531haizafrog wants to merge 2 commits intojfrog:masterfrom
haizafrog wants to merge 2 commits intojfrog:masterfrom
Conversation
- Updated the error handling in the `updateServerDetails` method to log a warning if the ping to the target Artifactory fails, while allowing for the possibility of transferring to a new server. - Added an informational log message for successful pings to enhance visibility during configuration updates. - Commented out the lines for clearing refresh tokens to prevent accidental token misuse during transfers.
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
…iguration - Eliminated commented-out lines related to clearing refresh tokens to streamline the code and reduce confusion. - This change enhances code clarity while maintaining the existing functionality of the transfer configuration process.
jf-Harsh
approved these changes
Mar 24, 2026
haizafrog
requested review from
amithins
and removed request for
amithins and
sverdlov93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the error handling in the
updateServerDetailsmethod to log a warning if the ping to the target Artifactory fails, while allowing for the possibility of transferring to a new server.Added an informational log message for successful pings to enhance visibility during configuration updates.
Commented out the lines for clearing refresh tokens to prevent accidental token misuse during transfers.
All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the master branch.
I used gofmt for formatting the code before submitting the pull request.