Skip to content

Refactor transfer configuration error handling and logging #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haizafrog wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor transfer configuration error handling and logging #1531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7c29a
Refactor transfer configuration error handling and logging
haizafrog Mar 22, 2026
6d0ba76
Remove commented-out code for refresh token clearing in transfer conf…
haizafrog Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions artifactory/commands/transferconfig/transferconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ func (tcc *TransferConfigCommand) createImportPollingAction(rtDetails *httputils
newServerDetails.SetPassword(tcc.SourceServerDetails.GetPassword())
newServerDetails.SetAccessToken(tcc.SourceServerDetails.GetAccessToken())


tcc.TargetArtifactoryManager, err = utils.CreateServiceManager(newServerDetails, -1, 0, false)
if err != nil {
return true, nil, err
Expand Down Expand Up @@ -504,9 +505,10 @@ func (tcc *TransferConfigCommand) updateServerDetails() error {
pingCmd := generic.NewPingCommand().SetServerDetails(newTargetServerDetails)
err := pingCmd.Run()
if err != nil {
return err
log.Warn("Ping to the target Artifactory failed. Please Ignore this warning if you are transferring the config to a new Artifactory server. Error: ", err)
} else {
log.Info("Ping to the target Artifactory was successful. Updating the server configuration in JFrog CLI.")
}
log.Info("Ping to the target Artifactory was successful. Updating the server configuration in JFrog CLI.")

// Update the server details in JFrog CLI configuration
configCmd := commands.NewConfigCommand(commands.AddOrEdit, newTargetServerDetails.ServerId).SetInteractive(false).SetDetails(newTargetServerDetails)
Expand Down Expand Up @@ -573,4 +575,4 @@ func (tcc *TransferConfigCommand) validateServerPrerequisites() (err error) {
}
// Make sure that the target Artifactory is empty and the config-import plugin is installed
return tcc.validateTargetServer()
}
}
Loading