Merged
Conversation
mlubin
reviewed
Jul 14, 2019
Member
mlubin
left a comment
mlubin
left a comment
There was a problem hiding this comment.
I reviewed only the docs, haven't looked at the code yet.
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 93.99% 94.06% +0.06%
==========================================
Files 59 59
Lines 6542 6702 +160
==========================================
+ Hits 6149 6304 +155
- Misses 393 398 +5
Continue to review full report at Codecov.
|
mlubin
reviewed
Jul 16, 2019
mlubin
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #759. It also refactors implementation of names to share more code with
UniversalFallbackthat will also be used by bridges in #759Closes #511