feat(web): implement multi-token suggestion-application range calculation 🚂#15782
Draft
jahorton wants to merge 2 commits intofeat/web/correction-search-abstractionfrom
Draft
feat(web): implement multi-token suggestion-application range calculation 🚂#15782jahorton wants to merge 2 commits intofeat/web/correction-search-abstractionfrom
jahorton wants to merge 2 commits intofeat/web/correction-search-abstractionfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
web/
web/predictive-text/
change
jahorton
force-pushed
the
refactor/web/build-and-map-predictions
branch
from
7163830 to
04e6479
Compare
jahorton
changed the base branch from
refactor/web/build-and-map-predictions
to
feat/web/correction-search-abstraction
jahorton
force-pushed
the
change/web/suggestion-range
branch
3 times, most recently
from
9ce31bd to
36335f1
Compare
jahorton
changed the title
…tion This PR calculates the range of context - possibly comprised of multiple tokens - removed from the prior context and/or appended via incoming input - caused when applying a suggestion. This new approach is much better suited toward operation under whitespace fat-fingering conditions than the original approach. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
change/web/suggestion-range
branch
from
36335f1 to
0aa15b7
Compare
jahorton
force-pushed
the
change/web/suggestion-range
branch
from
0aa15b7 to
be26deb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR calculates the range of context - possibly comprised of multiple tokens - removed from the prior context and/or appended via incoming input - caused when applying a suggestion. This new approach is much better suited toward operation under whitespace fat-fingering conditions than the original approach.
Build-bot: skip build:web
Test-bot: skip