refactor(web): move and rename SearchResult as TokenResultMapping 🚂#15814
Open
jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
Open
refactor(web): move and rename SearchResult as TokenResultMapping 🚂#15814jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
jahorton wants to merge 2 commits intorefactor/web/build-and-map-predictionsfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Apr 9, 2026
Build-bot: skip build:web Test-bot: skip
c92585c to
77b8af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of four PRs designed to, in sequence, add an abstraction layer to the correction-search algorithm so that we can use the same core code to search for corrections in different ways.
In particular, up until now, we've always searched for corrections for just one token at a time - the current token. To better support whitespace fat-fingering, we'll need the ability to answer the following question: "Which tokenization pattern is the closest to matching the current text after corrections?" The core logic of the search is the same, but the backing data will be different - something that abstraction can handle well.
To accomplish the goal of abstracting the core search mechanisms, work will proceed in the following manner:
Build-bot: skip build:web
Test-bot: skip