feat(web): add classes for use in multi-token correction 🚂#15818
Draft
jahorton wants to merge 3 commits intochange/web/suggestion-rangefrom
Draft
feat(web): add classes for use in multi-token correction 🚂#15818jahorton wants to merge 3 commits intochange/web/suggestion-rangefrom
jahorton wants to merge 3 commits intochange/web/suggestion-rangefrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
feat/web/correction-search-abstraction
branch
from
6cedadc to
eaf419f
Compare
This was referenced Apr 9, 2026
jahorton
changed the base branch from
feat/web/correction-search-abstraction
to
change/web/suggestion-range
jahorton
force-pushed
the
feat/web/multi-token-corrector
branch
from
34e48e8 to
b9480ec
Compare
jahorton
force-pushed
the
feat/web/multi-token-corrector
branch
from
18043de to
fde6b02
Compare
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/multi-token-corrector
branch
from
fde6b02 to
2ae39dd
Compare
jahorton
force-pushed
the
feat/web/multi-token-corrector
branch
from
2ae39dd to
cd19326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 🚧
As mentioned in the description of #15814, up until now, we've always searched for corrections for just one token at a time - the current token. To better support whitespace fat-fingering, we'll need the ability to answer the following question: "Which tokenization pattern is the closest to matching the current text after corrections?" To answer said question, we'll need to search for phrase-level corrections not focused on a specific word, prioritizing the most likely combination of tokenization-pattern and correction-cost for one of the pattern's tokens.
Build-bot: skip build:web
Test-bot: skip