Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts panel/preview sizing rules to address overflow scrolling behavior in the preview area of the app shell.
Changes:
- Set
.preview-hosttoheight: 100%to better fill the available preview area. - Update collapsed-horizontal panel toggle sizing to a fixed square control.
- Allow preview panel content to scroll (
overflow: auto) and tweak min-height behavior in default grid layouts. - Prune/reorder items in
docs/next-steps.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles/preview-controls.css | Makes the preview host fill available height. |
| src/styles/panels-editor.css | Standardizes collapsed-horizontal collapse toggle sizing. |
| src/styles/layout-shell.css | Adjusts preview panel min-height and enables scrolling within preview content. |
| docs/next-steps.md | Removes earlier roadmap items and renumbers remaining sections. |
Comments suppressed due to low confidence (1)
src/styles/preview-controls.css:15
height: 100%on.preview-hostmay not take effect in the default ShadowRoot mode becauserender-runtime.jsinjects:host { all: initial; ... }base styles into the shadow root and does not setheight/max-height. Consider adding a preview-host height CSS var to the shadow base styles (or explicitly settingheight: 100%there) so light DOM and ShadowRoot mode behave consistently.
display: var(--preview-host-display);
flex: var(--preview-host-flex);
height: 100%;
min-height: var(--preview-host-min-height);
max-height: 100%;
padding: var(--preview-host-padding);
overflow: var(--preview-host-overflow);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.