Skip to content

fix: overflow scrolling.#14

Merged
knightedcodemonkey merged 1 commit intomainfrom
bananas
Mar 18, 2026
Merged

fix: overflow scrolling.#14
knightedcodemonkey merged 1 commit intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 00:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts panel/preview sizing rules to address overflow scrolling behavior in the preview area of the app shell.

Changes:

  • Set .preview-host to height: 100% to better fill the available preview area.
  • Update collapsed-horizontal panel toggle sizing to a fixed square control.
  • Allow preview panel content to scroll (overflow: auto) and tweak min-height behavior in default grid layouts.
  • Prune/reorder items in docs/next-steps.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/styles/preview-controls.css Makes the preview host fill available height.
src/styles/panels-editor.css Standardizes collapsed-horizontal collapse toggle sizing.
src/styles/layout-shell.css Adjusts preview panel min-height and enables scrolling within preview content.
docs/next-steps.md Removes earlier roadmap items and renumbers remaining sections.
Comments suppressed due to low confidence (1)

src/styles/preview-controls.css:15

  • height: 100% on .preview-host may not take effect in the default ShadowRoot mode because render-runtime.js injects :host { all: initial; ... } base styles into the shadow root and does not set height/max-height. Consider adding a preview-host height CSS var to the shadow base styles (or explicitly setting height: 100% there) so light DOM and ShadowRoot mode behave consistently.
  display: var(--preview-host-display);
  flex: var(--preview-host-flex);
  height: 100%;
  min-height: var(--preview-host-min-height);
  max-height: 100%;
  padding: var(--preview-host-padding);
  overflow: var(--preview-host-overflow);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit ce96325 into main Mar 18, 2026
5 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 18, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants