Export outbound_payments directly rather than via re-exports
#4370
+68
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @wpaulino was un-assigned. |
Every time we use re-exports to hide a module in the public API we end up accidentally breaking the public API due to accidental seals. We did this yet again in e9c6bbc where we moved to using a `CustomTlvs` field in the public API for `RecipientOnionFields` but forgot to re-export it, making it impossible to use downstream. Instead, here, we just actually export `outbound_payments`. Compilation fixes by Claude.
TheBlueMatt
force-pushed
the
2026-02-no-re-exports
branch
from
1d17b00 to
0bc5c95
Compare
TheBlueMatt
added a commit
to TheBlueMatt/ldk-node
that referenced
this pull request
Feb 2, 2026
lightningdevkit/rust-lightning#4263 and lightningdevkit/rust-lightning#4370 changed the `lightning` API, which we update to here. We also switch to using a `Cargo.toml` `[patch...]` to avoid having to update the `bitcoin-payment-instructions` dep after each bump.
valentinewallace
approved these changes
Feb 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
==========================================
+ Coverage 85.98% 86.00% +0.02%
==========================================
Files 156 156
Lines 102641 102641
Branches 102641 102641
==========================================
+ Hits 88258 88279 +21
+ Misses 11873 11855 -18
+ Partials 2510 2507 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Feb 3, 2026
tnull
added a commit
to tnull/ldk-node
that referenced
this pull request
Feb 3, 2026
lightningdevkit/rust-lightning#4263 and lightningdevkit/rust-lightning#4370 changed the `lightning` API, which we update to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we use re-exports to hide a module in the public API we end up accidentally breaking the public API due to accidental seals. We did this yet again in
e9c6bbc where we moved to using a
CustomTlvsfield in the public API forRecipientOnionFieldsbut forgot to re-export it, making it impossible to use downstream.Instead, here, we just actually export
outbound_payments.