Skip to content

upcoming: [UIE-10426] - Add new endpoints, types and Queries for Reserved IPs#13517

Open
grevanak-akamai wants to merge 5 commits intolinode:developfrom
grevanak-akamai:feature/UIE-10426-api-queries-for-reserved-ips
Open

upcoming: [UIE-10426] - Add new endpoints, types and Queries for Reserved IPs#13517
grevanak-akamai wants to merge 5 commits intolinode:developfrom
grevanak-akamai:feature/UIE-10426-api-queries-for-reserved-ips

Conversation

@grevanak-akamai
Copy link
Contributor

Description 📝

Added new API endpoints, types, and queries for Network Load Balancers. Also updated existing types and schemas to include reserved IP API changes.

Changes 🔄

  • Added new endpoints:

    POST /networking/reserved/ips
    PUT /networking/reserved/ips/{address}
    GET /networking/reserved/ips
    GET /networking/reserved/ips/{address}
    DELETE /networking/reserved/ips/{address}
    GET /networking/reserved/ips/types

  • Updated existing endpoints

    POST /networking/ips
    PUT /networking/ips/{address}
    POST /nodebalancers

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Apr

How to test 🧪

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@grevanak-akamai grevanak-akamai requested a review from a team as a code owner March 23, 2026 13:31
@grevanak-akamai grevanak-akamai added the Reserve IP Reserve IP label Mar 23, 2026
@grevanak-akamai grevanak-akamai self-assigned this Mar 23, 2026
@grevanak-akamai grevanak-akamai marked this pull request as draft March 23, 2026 13:45
@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-10426-api-queries-for-reserved-ips branch from 27347e6 to d4e799e Compare March 23, 2026 13:54
@grevanak-akamai grevanak-akamai marked this pull request as ready for review March 23, 2026 14:20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the folder name should be networking-ips

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is existing folder. So keeping it as is to avoid any regression impact.

@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-10426-api-queries-for-reserved-ips branch 2 times, most recently from 4ed72dd to e66f7c4 Compare March 24, 2026 12:26
@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-10426-api-queries-for-reserved-ips branch from e66f7c4 to a652065 Compare March 24, 2026 12:32
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing878 Passing11 Skipped42m 41s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » creates an LKE-E cluster with the account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

public: boolean;
rdns: null | string;
region: string;
reserved: boolean;
Copy link
Contributor

@tanushree-akamai tanushree-akamai Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the API def this should be optional, it will only be present if feature flag is enabled:
reserved?: boolean;
Image

API typedef link

Copy link
Contributor Author

@grevanak-akamai grevanak-akamai Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be fine. After adding customer tag, I see reserved field is available all the time. So our types file still matches API response. If we add customer tag and still the field is shown optionally, then it makes sense to make it an optional field in our types file.

Copy link
Contributor

@tanushree-akamai tanushree-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Ready for Review Reserve IP Reserve IP

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants